android: fix Gradle deps, drop Flipper, upgrade Fresco #16369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (4)
|
siddarthkay
force-pushed
the
nix/fix-gradle-deps
branch
from
c076265
to
cc6963e
Compare
There are a few fixes here:
* Changes format of Gradle deps to `:buildEnvironment` and `:dependencies`:
```
Cannot locate tasks that match '::buildEnvironment'. The path should not include an empty segment (try ':buildEnvironment' instead).
```
* Fix for GNU Parallel tool to use stdin for list of arguments:
```
nix/deps/gradle/generate.sh: line 55: parallel: Argument list too long
```
* Update of Facebook Fresco dependencies from `2.2.0` to `2.5.0` to fix:
```
> echo com.facebook.fresco:animated-gif:2.2.0 | ./go-maven-resolver > /dev/null
finder.go:121: error: 'no pom data' for: <Dep ID=com.facebook.fresco:imagepipeline-native:2.2.0 O=false S=compile >
finder.go:121: error: 'no pom data' for: <Dep ID=com.facebook.fresco:memory-type-native:2.2.0 O=false S=compile >
finder.go:121: error: 'no pom data' for: <Dep ID=com.facebook.fresco:imagepipeline:2.2.0 O=false S=compile >
finder.go:121: error: 'no pom data' for: <Dep ID=com.facebook.fresco:drawee:2.2.0 O=false S=runtime >
finder.go:121: error: 'no pom data' for: <Dep ID=com.facebook.fresco:memory-type-java:2.2.0 O=false S=compile >
finder.go:121: error: 'no pom data' for: <Dep ID=com.facebook.fresco:fbcore:2.2.0 O=false S=runtime >
```
* Remove Flipper to avoid pulling in Fresco `2.2.0` versions:
```
+--- com.facebook.flipper:flipper-fresco-plugin:0.54.0
| +--- com.facebook.fresco:fresco:2.2.0 -> 2.5.0
| +--- com.facebook.fresco:flipper:2.2.0
| \--- com.facebook.fresco:stetho:2.2.0
```
Thanks for help from Sidarth.
Resolves: #16367
Signed-off-by: Jakub Sokołowski <[email protected]>
jakubgs
force-pushed
the
nix/fix-gradle-deps
branch
from
cc6963e
to
33b2e12
Compare
smohamedjavid
approved these changes
Jun 23, 2023
vkjr
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few fixes here:
:buildEnvironmentand:dependencies:2.2.0to2.5.0to fix:2.2.0versions:Thanks for help from Sidarth.
Resolves: