js: remove unused visual tests and detox package #16372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also remove Additionally you can remove folder: I think that's all there is to visual tests. |
|
actually there is also some scripts in the Make file -> these can be removed too |
Jenkins BuildsClick to see older builds (9)
|
|
@J-Son89, done, cleaned up visual tests too |
yakimant
changed the title
J-Son89
approved these changes
Jun 23, 2023
yakimant
changed the title
yakimant
added a commit
that referenced
this pull request
Jun 26, 2023
After the nixpkgs upgrade we started to have Xcode command line tools installation popup on each make test, dtrace-provider was failing meanwhile: #16356 It appeared, that it was failing before the upgrade with different issue: #16356 dtrace-provider is a dependency for detox, which was added for visiual tests in #14329 These tests don't run. This build issues didn't cause any problems, because it was not obligatary. See NODE_DTRACE_PROVIDER_REQUIRE option, which can enforce this requirement. See #16356 for more details. In this PR we disable detox dependency for now. And also Visual Tests.
yakimant
force-pushed
the
remove_unused_detox
branch
from
6d68b8f
to
ad463e1
Compare
yakimant
added a commit
that referenced
this pull request
Jun 26, 2023
After the nixpkgs upgrade we started to have Xcode command line tools installation popup on each make test, dtrace-provider was failing meanwhile: #16356 It appeared, that it was failing before the upgrade with different issue: #16356 dtrace-provider is a dependency for detox, which was added for visiual tests in #14329 These tests don't run. This build issues didn't cause any problems, because it was not obligatary. See NODE_DTRACE_PROVIDER_REQUIRE option, which can enforce this requirement. See #16356 for more details. In this PR we disable detox dependency for now. And also Visual Tests.
yakimant
force-pushed
the
remove_unused_detox
branch
from
ad463e1
to
9e20194
Compare
After the nixpkgs upgrade we started to have Xcode command line tools installation popup on each make test, dtrace-provider was failing meanwhile: #16356 It appeared, that it was failing before the upgrade with different issue: #16356 dtrace-provider is a dependency for detox, which was added for visiual tests in #14329 These tests don't run. This build issues didn't cause any problems, because it was not obligatary. See NODE_DTRACE_PROVIDER_REQUIRE option, which can enforce this requirement. See #16356 for more details. In this PR we disable detox dependency for now. And also Visual Tests.
yakimant
force-pushed
the
remove_unused_detox
branch
from
9e20194
to
43ef6db
Compare
codemaster115
pushed a commit
that referenced
this pull request
Jul 7, 2023
After the nixpkgs upgrade we started to have Xcode command line tools installation popup on each make test, dtrace-provider was failing meanwhile: #16356 It appeared, that it was failing before the upgrade with different issue: #16356 dtrace-provider is a dependency for detox, which was added for visiual tests in #14329 These tests don't run. This build issues didn't cause any problems, because it was not obligatary. See NODE_DTRACE_PROVIDER_REQUIRE option, which can enforce this requirement. See #16356 for more details. In this PR we disable detox dependency for now. And also Visual Tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After the
nixpkgsupgrade we started to have Xcode command line tools installation popup on eachmake test,dtrace-providerwas failing meanwhile:#16356 (comment)
It appeared, that it was failing before the upgrade with different issue:
#16356 (comment)
dtrace-provideris a dependency fordetox, which was added for visiual tests in #14329These tests don't run.
This build issues didn't cause any problems, because it was not obligatary.
See
NODE_DTRACE_PROVIDER_REQUIREoption, which can enforce this requirement.See #16356 for more details.
In this PR we disable
detoxdependency for now.And also Visual Tests.
Review notes
There are many libs removed from yarn.lock.
Looks a bit suspicious, or maybe it's just
detoxhas so many dependencies.status: ready