Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use with theme for step component #16399

Merged
merged 1 commit into from
Jun 30, 2023
Merged

chore: use with theme for step component #16399

merged 1 commit into from
Jun 30, 2023

Conversation

J-Son89
Copy link
Contributor

@J-Son89 J-Son89 commented Jun 27, 2023 •
edited
Loading

Related to: #16400

A small pr which refactors the step component and it's uses within the application.

To test - the preview screens for Step component can be checked, additionally the info menu for "forgot password" can be checked as the step component is used there.
I believe it is also used in the Find Sync code info box on the onboarding screens, in app and also in the community overview page where it shows the community rules.

@J-Son89 J-Son89 self-assigned this Jun 27, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Jun 27, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (16)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 67810fa #1 2023-06-27 06:42:40 ~6 min ios 📱ipa 📲
✔️ 67810fa #1 2023-06-27 06:43:01 ~6 min android-e2e 🤖apk 📲
✔️ 67810fa #1 2023-06-27 06:43:21 ~7 min android 🤖apk 📲
✔️ 67810fa #1 2023-06-27 06:43:29 ~7 min tests 📄log
✔️ 0e14209 #2 2023-06-27 10:33:56 ~6 min android-e2e 🤖apk 📲
✔️ 0e14209 #2 2023-06-27 10:36:08 ~8 min android 🤖apk 📲
✔️ 0e14209 #2 2023-06-27 10:36:43 ~9 min ios 📱ipa 📲
✔️ 0e14209 #2 2023-06-27 10:36:58 ~9 min tests 📄log
✔️ bca66b4 #3 2023-06-28 08:49:47 ~6 min android 🤖apk 📲
✔️ bca66b4 #3 2023-06-28 08:50:47 ~7 min android-e2e 🤖apk 📲
✔️ bca66b4 #3 2023-06-28 08:50:56 ~7 min ios 📱ipa 📲
✔️ bca66b4 #3 2023-06-28 08:51:53 ~8 min tests 📄log
✔️ 72fcaca #4 2023-06-30 12:49:54 ~7 min ios 📱ipa 📲
❌ 72fcaca #4 2023-06-30 12:54:54 ~12 min tests 📄log
✔️ 72fcaca #4 2023-06-30 12:57:29 ~15 min android 🤖apk 📲
✔️ 72fcaca #4 2023-06-30 12:57:51 ~15 min android-e2e 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1e44486 #5 2023-06-30 14:26:14 ~5 min ios 📱ipa 📲
✔️ 1e44486 #5 2023-06-30 14:26:40 ~6 min android-e2e 🤖apk 📲
✔️ 1e44486 #5 2023-06-30 14:28:03 ~7 min android 🤖apk 📲
✔️ 1e44486 #5 2023-06-30 14:30:36 ~9 min tests 📄log
✔️ f2d675a #6 2023-06-30 15:39:49 ~5 min ios 📱ipa 📲
✔️ f2d675a #6 2023-06-30 15:40:10 ~5 min android-e2e 🤖apk 📲
✔️ f2d675a #6 2023-06-30 15:41:01 ~6 min android 🤖apk 📲
✔️ f2d675a #6 2023-06-30 15:45:20 ~11 min tests 📄log

@J-Son89 J-Son89 marked this pull request as ready for review June 27, 2023 10:27
@status-im-auto
Copy link
Member

70% of end-end tests have passed

Total executed tests: 33
Failed tests: 10
Passed tests: 23

IDs of failed tests: 703086,702783,702782,702850,702958,702732,702851,702731,702745,703133

Failed tests (10)

Click to expand
  • Rerun failed tests

    • Class TestActivityMultipleDevicePR:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958

    Device 1: Looking for activity center element: 'user2'
    Device 1: Find `Button` by `xpath`: `//*[contains(@text, 'user2')]/ancestor::*[@content-desc='activity']//*[@content-desc="activity-title"]` 

    medium/test_activity_center.py:331: in test_activity_center_admin_notification_accept_swipe
    if reply_element.title.text != 'Join request':
../views/base_element.py:209: in text
    return self.find_element().text
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[contains(@text, 'user2')]/ancestor::*[@content-desc='activity']//*[@content-desc="activity-title"]` is not found on the screen



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    # STEP: Device1 goes back online and checks that 1-1 chat will be fetched
    Device 1: Looking for a message by text: test message 

    critical/chats/test_1_1_public_chats.py:1252: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to Delivered, it's Sending after back up online!

    [[Issue with messages not being sent for a long time]]

    Device sessions

    2. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

    Device 1: Find SendMessageButton by accessibility id: send-message-button
    Device 1: Tap on found: SendMessageButton 

    critical/chats/test_1_1_public_chats.py:938: in test_1_1_chat_emoji_send_reply_and_open_link
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message with URL was not received



    Device sessions

    3. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Find MemberPhoto by xpath: //*[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='user-avatar']
    Device 2: Image differs from template to 5.814352596507353 percents 

    critical/chats/test_1_1_public_chats.py:1076: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Image of user in 1-1 chat is too different from template!



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086

    Device 1: Find Button by accessibility id: mark-as-read
    Device 1: Tap on found: Button 

    critical/test_public_chat_browsing.py:837: in test_community_mark_all_messages_as_read
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter is not shown in home > Commmunity element



    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Tap on found: Button
    Device 2: Looking for activity center element: 'sender' 

    medium/test_activity_center.py:73: in test_activity_center_contact_request_decline
    message_element.wait_for_element(30)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `2`: `Button` by` xpath`: `//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']//*[@content-desc="activity-message-body"]` is not found on the screen after wait_for_element



    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 2: Find Button by accessibility id: new-chat-button
    Device 2: Find Button by accessibility id: add-a-contact 

    medium/test_activity_center.py:87: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.home_2.add_contact(self.public_key_1, remove_from_contacts=True)
../views/home_view.py:359: in add_contact
    self.add_a_contact_chat_bottom_sheet_button.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `add-a-contact` is not found on the screen



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Tap on found: ProfileSendMessageButton
    Device 1: Find Text by xpath: //*[@content-desc='user-avatar']/../following-sibling::android.widget.TextView 

    critical/test_public_chat_browsing.py:391: in test_restore_multiaccount_with_waku_backup_remove_switch
    shown_name_text = chat.user_name_text_new_UI.text
../views/base_element.py:391: in text
    text = self.find_element().text
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: Text by xpath: `//*[@content-desc='user-avatar']/../following-sibling::android.widget.TextView` is not found on the screen



    Device sessions

    Passed tests (23)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_message_edit, id: 702843
    Device sessions

    5. test_community_message_delete, id: 702839
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_mentions_push_notification, id: 702786
    Device sessions

    8. test_community_one_image_send_reply, id: 702859
    Device sessions

    9. test_community_several_images_send_reply, id: 703194
    Device sessions

    10. test_community_leave, id: 702845
    Device sessions

    11. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    @VolodLytvynenko VolodLytvynenko self-assigned this Jun 30, 2023
    @VolodLytvynenko
    Copy link
    Contributor

    @J-Son89 could you please take a look at the integration failed tests https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-16399/4/consoleText

    @J-Son89
    Copy link
    Contributor Author

    J-Son89 commented Jun 30, 2023

    Hi @VladimrLitvinenko, it was the issue with the date time test that @ilmotta addresse recently. I rebased and pushed so it should be fine now 👍

    @VolodLytvynenko
    Copy link
    Contributor

    Hi @VladimrLitvinenko, it was the issue with the date time test that @ilmotta addresse recently. I rebased and pushed so it should be fine now 👍

    @J-Son89 Thanx for the clarification. No issues from my side. PR can be merged

    @J-Son89 J-Son89 merged commit 4c0a8d9 into develop Jun 30, 2023
    @J-Son89 J-Son89 deleted the jc/step-refactor branch June 30, 2023 16:02
    codemaster115 pushed a commit that referenced this pull request Jul 7, 2023
    @J-Son89 @codemaster115
    chore: use with theme for step component (#16399)
    8113060
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @OmarBasem OmarBasem OmarBasem approved these changes

    @jo-mut jo-mut jo-mut approved these changes

    @yqrashawn yqrashawn Awaiting requested review from yqrashawn

    @erikseppanen erikseppanen Awaiting requested review from erikseppanen

    Assignees

    @J-Son89 J-Son89

    @VolodLytvynenko VolodLytvynenko

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @J-Son89 @status-im-auto @VolodLytvynenko @jo-mut @OmarBasem