Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix app crash during key generation #16984

Merged
merged 1 commit into from
Aug 11, 2023
Merged

fix app crash during key generation #16984

merged 1 commit into from
Aug 11, 2023

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented Aug 11, 2023

fix #16983

status: ready

@qfrank qfrank requested a review from cammellos August 11, 2023 09:25
@qfrank qfrank self-assigned this Aug 11, 2023
@pavloburykh pavloburykh self-assigned this Aug 11, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Aug 11, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e970a22 #1 2023-08-11 09:34:21 ~8 min ios 📱ipa 📲
✔️ e970a22 #1 2023-08-11 09:34:29 ~9 min android-e2e 🤖apk 📲
✔️ e970a22 #1 2023-08-11 09:36:40 ~11 min tests 📄log
✔️ e970a22 #1 2023-08-11 09:37:11 ~11 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 69d3fcb #2 2023-08-11 11:28:55 ~4 min tests 📄log
✔️ 69d3fcb #2 2023-08-11 11:32:36 ~7 min ios 📱ipa 📲
✔️ 69d3fcb #2 2023-08-11 11:33:31 ~8 min android-e2e 🤖apk 📲
✔️ 69d3fcb #2 2023-08-11 11:33:32 ~8 min android 🤖apk 📲
✔️ f8b3b62 #3 2023-08-11 11:40:52 ~6 min ios 📱ipa 📲
✔️ f8b3b62 #3 2023-08-11 11:43:44 ~9 min android-e2e 🤖apk 📲
✔️ f8b3b62 #3 2023-08-11 11:43:52 ~9 min android 🤖apk 📲
✔️ f8b3b62 #3 2023-08-11 11:44:08 ~9 min tests 📄log

@status-im-auto
Copy link
Member

86% of end-end tests have passed

Total executed tests: 43
Failed tests: 6
Passed tests: 37

IDs of failed tests: 702786,702731,702809,702948,703133,702732

Failed tests (6)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_mentions_push_notification, id: 702786

    # STEP: Admin gets push notification with the mention and tap it
    Device 1: Getting PN by 'user_1' 

    critical/test_public_chat_browsing.py:1082: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:177: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin



    Device sessions

    2. test_community_markdown_support, id: 702809

    Device 1: Looking for a message by text: quote reply (one row)
    Device 2: Looking for a message by text: quote reply (one row) 

    critical/test_public_chat_browsing.py:1132: in test_community_markdown_support
    self.errors.verify_no_errors()
base_test_case.py:177: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 bold text in underscores is not displayed with markdown in community channel for the recipient (device 1)



    Device sessions

    3. test_community_hashtag_links_to_community_channels, id: 702948 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Can't invite user to closed community https://github.com//issues/16968]]

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Restoring communities issue: 16787; restoring contacts issue: 15500]]

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (37)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_activity_center_mentions, id: 702957
    Device sessions

    4. test_navigation_jump_to, id: 702936
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    4. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    5. test_group_chat_mute_chat, id: 703495
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    5. test_community_discovery, id: 703503
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_leave, id: 702845
    Device sessions

    2. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    3. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_one_image_send_reply, id: 702859
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_several_images_send_reply, id: 703194
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_edit_message, id: 702855
    Device sessions

    2. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    5. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    6. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    7. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    8. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    10. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @qfrank thanx for the fix! Let's merge it!

    @qfrank qfrank force-pushed the fix/app_crash_during_key_generation branch from 69d3fcb to f8b3b62 Compare August 11, 2023 11:33
    @cammellos cammellos force-pushed the fix/app_crash_during_key_generation branch from f8b3b62 to 715fc13 Compare August 11, 2023 11:48
    @cammellos cammellos merged commit 715fc13 into develop Aug 11, 2023
    2 checks passed
    @cammellos cammellos deleted the fix/app_crash_during_key_generation branch August 11, 2023 11:48
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @cammellos cammellos cammellos approved these changes

    Assignees

    @qfrank qfrank

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    App Crash During Key Generation
    4 participants
    @qfrank @status-im-auto @pavloburykh @cammellos