feat: implement interactive graphs #17029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (111)
|
briansztamfater
force-pushed
the
feat/interactive-charts
branch
from
655ad82
to
da03998
Compare
briansztamfater
force-pushed
the
feat/interactive-charts
branch
9 times, most recently
from
ae5d9d5
to
93d8579
Compare
briansztamfater
changed the title
briansztamfater
requested review from
J-Son89,
erikseppanen,
smohamedjavid,
OmarBasem and
mmilad75
OmarBasem
approved these changes
Aug 29, 2023
| :padding-horizontal 5 | ||
| :padding-top -10 | ||
| :height 19 | ||
| :line-height 14.62 |
There was a problem hiding this comment.
is it really 14.62 in the designs?
There was a problem hiding this comment.
Actually no, it is just a tweak to correctly center vertically the text within the reference line text, that for some reason gets moved when rendered in the graph
J-Son89
approved these changes
Aug 29, 2023
|
@Francesca-G kindly review this PR 🙏 |
briansztamfater
force-pushed
the
feat/interactive-charts
branch
from
7de57c7
to
17c4c08
Compare
|
@briansztamfater the negative / positive option doesn't seem to change the color to red / green as expected, let me know if it's a problem on my side :) |
briansztamfater
force-pushed
the
feat/interactive-charts
branch
6 times, most recently
from
f146d93
to
c80dfdd
Compare
@Francesca-G sorry about that, it was an issue affecting only PR builds, now should be fixed! |
Signed-off-by: Brian Sztamfater <[email protected]>
briansztamfater
force-pushed
the
feat/interactive-charts
branch
from
c80dfdd
to
60e7c76
Compare
alwx
pushed a commit
that referenced
this pull request
Sep 6, 2023
Signed-off-by: Brian Sztamfater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16956
Summary
This PR adds an implementation of interactive charts to quo2 previews. It also implements Graph axe, Lowest price and Graph pointer as they are part of the chart component itself and are rendered inside the library, so there are not separate quo2 component implementations for those.
Also moved wallet graph utils namespace into a common namespace shared by wallet graph and interactive graph components. Added a bunch of functions there with their corresponding unit tests.
Also created and added as a dependency our own fork of
react-native-gifted-chartsas there were some adjustments needed to comply with Figma designs as pixel perfect as possible (gradients to strip line, adjustments on x and y axis label logic, and many other things).Results
Screenshots
Recordings
interactive.graph.demo.mp4
interactive.graph.demo.dark.mp4
Platforms
Steps to test
status: ready