Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Fix: wallet graph gradient #17093

Merged
merged 4 commits into from
Aug 23, 2023
Merged

UI Fix: wallet graph gradient #17093

merged 4 commits into from
Aug 23, 2023

Conversation

OmarBasem
Copy link
Contributor

@OmarBasem OmarBasem commented Aug 23, 2023

fixes: #17092

A small fix for the wallet graph gradient background.

The wallet graph gradient background needs to have position absolute otherwise it would occupy more space than the actual component height (which is 96) when used in the screens

The component UI is still the same

@OmarBasem OmarBasem changed the title Fix/wallet graph gradient UI Fix: wallet graph gradient Aug 23, 2023
@OmarBasem OmarBasem self-assigned this Aug 23, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Aug 23, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
30070d4 #1 2023-08-23 11:37:58 ~4 min tests 📄log
✔️ 30070d4 #1 2023-08-23 11:39:09 ~5 min android 🤖apk 📲
✔️ 30070d4 #1 2023-08-23 11:39:14 ~5 min android-e2e 🤖apk 📲
✔️ 30070d4 #1 2023-08-23 11:39:37 ~6 min ios 📱ipa 📲
✔️ fc4e9be #2 2023-08-23 16:12:54 ~6 min android 🤖apk 📲
✔️ fc4e9be #2 2023-08-23 16:13:09 ~6 min ios 📱ipa 📲
✔️ fc4e9be #2 2023-08-23 16:14:48 ~7 min android-e2e 🤖apk 📲
✔️ fc4e9be #2 2023-08-23 16:16:43 ~9 min tests 📄log

Copy link
Member

@briansztamfater briansztamfater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! BTW, tests are failing due to linting issues, we should fix that.

@OmarBasem OmarBasem merged commit 914604b into develop Aug 23, 2023
2 checks passed
@OmarBasem OmarBasem deleted the fix/wallet-graph-gradient branch August 23, 2023 16:19
andresceballosm pushed a commit to andresceballosm/status-mobile that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

Wallet Graph gradient background
3 participants