Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove hole view code with error #17164

Merged
merged 1 commit into from
Sep 1, 2023
Merged

fix: remove hole view code with error #17164

merged 1 commit into from
Sep 1, 2023

Conversation

J-Son89
Copy link
Contributor

@J-Son89 J-Son89 commented Sep 1, 2023 •
edited
Loading

400

Removes the hole view code which is incorrectly using nil in the quo2 top nav component.
Will add this code back in a separate pr once it is stable 👍

@J-Son89 J-Son89 self-assigned this Sep 1, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Sep 1, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7f6c80d #1 2023-09-01 08:02:19 ~6 min android-e2e 🤖apk 📲
✔️ 7f6c80d #1 2023-09-01 08:02:25 ~6 min android 🤖apk 📲
✔️ 7f6c80d #1 2023-09-01 08:03:48 ~7 min ios 📱ipa 📲
✔️ 7f6c80d #1 2023-09-01 08:05:22 ~9 min tests 📄log
✔️ 2f135d2 #2 2023-09-01 12:08:00 ~8 min ios 📱ipa 📲
✔️ 2f135d2 #2 2023-09-01 12:08:52 ~9 min android 🤖apk 📲
✔️ 2f135d2 #2 2023-09-01 12:09:04 ~9 min android-e2e 🤖apk 📲
✔️ 2f135d2 #2 2023-09-01 12:09:56 ~10 min tests 📄log

@pavloburykh pavloburykh self-assigned this Sep 1, 2023
@status-im-auto
Copy link
Member

47% of end-end tests have passed

Total executed tests: 43
Failed tests: 23
Passed tests: 20

IDs of failed tests: 702809,702733,702732,702813,702957,703495,703086,702948,702745,702783,703297,703503,703496,702936,702855,703202,703391,702786,702947,702807,702731,702808,702845

Failed tests (23)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086

    Device 1: Tap on found: Button
    Device 1: Click until `Text` by `accessibility id`: `community-description-text` will be presented 

    critical/test_public_chat_browsing.py:1022: in test_community_mark_all_messages_as_read
    self.errors.verify_no_errors()
base_test_case.py:187: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter is not shown in community channel element



    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957

    Device 2: Mention user user1 in the chat
    Device 2: Find ChatMessageInput by accessibility id: chat-message-input 

    medium/test_activity_center.py:336: in test_activity_center_mentions
    self.channel_2.mention_user(self.username_1)
../views/chat_view.py:1197: in mention_user
    self.chat_message_input.click_inside()
../views/chat_view.py:733: in click_inside
    location = self.find_element().location
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: ChatMessageInput by accessibility id: `chat-message-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936

    Device 2: Looking for a message by text: open community
    Device 2: Find BaseElement by xpath: //*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View'] 

    Test setup failed: medium/test_activity_center.py:175: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 

    Test setup failed: medium/test_activity_center.py:175: in prepare_devices
    self.chat_2.chat_element_by_text(self.community_name).view_community_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503

    Device 1: Image differs from template to 0.0031355315563725487 percents
    Device 1: Find Button by xpath: //*[@text="# general"]/../*[@content-desc="channel-avatar"] 

    critical/test_public_chat_browsing.py:341: in test_community_discovery
    self.errors.verify_no_errors()
base_test_case.py:187: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Button is different from expected discovery_general_channel.png!



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809 

    Test setup failed: critical/test_public_chat_browsing.py:1050: in prepare_devices
    self.home_1.communities_tab.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: CommunitiesTab by accessibility id: `communities-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_community_hashtag_links_to_community_channels, id: 702948 

    Test setup failed: critical/test_public_chat_browsing.py:1050: in prepare_devices
    self.home_1.communities_tab.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: CommunitiesTab by accessibility id: `communities-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    3. test_community_mentions_push_notification, id: 702786

    # STEP: Open community to message
    Device 1: Find CommunitiesTab by accessibility id: communities-stack-tab 

    Test setup failed: critical/test_public_chat_browsing.py:1050: in prepare_devices
    self.home_1.communities_tab.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: CommunitiesTab by accessibility id: `communities-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

    [[Issue with username in PN, issue #6 in https://github.com//issues/15500]]

    Device sessions

    4. test_community_leave, id: 702845 

    Test setup failed: critical/test_public_chat_browsing.py:1050: in prepare_devices
    self.home_1.communities_tab.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: CommunitiesTab by accessibility id: `communities-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733

    Device 1: Find Button by accessibility id: jump-to 

    critical/chats/test_1_1_public_chats.py:1273: in test_1_1_chat_text_message_delete_push_disappear
    self.chat_1.jump_to_card_by_text(self.username_2)
../views/base_view.py:639: in jump_to_card_by_text
    self.click_on_floating_jump_to()
../views/base_view.py:628: in click_on_floating_jump_to
    self.jump_to_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `jump-to` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_1_1_chat_push_emoji, id: 702813

    Device 1: Could not reach home view by pressing system back button
    Device 1: Find ChatsTab by accessibility id: chats-stack-tab 

    critical/chats/test_1_1_public_chats.py:1146: in test_1_1_chat_push_emoji
    self.device_1.profile_button.click()
../views/base_view.py:142: in click
    ChatsTab(self.driver).click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: ChatsTab by accessibility id: `chats-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Find MemberPhoto by xpath: //*[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='user-avatar']
    Device 2: Image differs from template to 7.188313802083333 percents 

    critical/chats/test_1_1_public_chats.py:1127: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    self.errors.verify_no_errors()
base_test_case.py:187: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Image of user in 1-1 chat is too different from template!



    Device sessions

    4. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Tap on found: Button
    Device 1: Find Button by accessibility id: jump-to 

    critical/chats/test_1_1_public_chats.py:1332: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.chat_1.jump_to_card_by_text(self.username_2)
../views/base_view.py:639: in jump_to_card_by_text
    self.click_on_floating_jump_to()
../views/base_view.py:628: in click_on_floating_jump_to
    self.jump_to_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `jump-to` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    5. test_1_1_chat_mute_chat, id: 703496

    Device 1: Could not reach home view by pressing system back button
    Device 1: Find ChatsTab by accessibility id: chats-stack-tab 

    critical/chats/test_1_1_public_chats.py:1382: in test_1_1_chat_mute_chat
    self.home_1.chats_tab.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: ChatsTab by accessibility id: `chats-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    6. test_1_1_chat_edit_message, id: 702855

    Device 2: Tap on found: Button
    Device 1: Find Button by accessibility id: jump-to 

    critical/chats/test_1_1_public_chats.py:1185: in test_1_1_chat_edit_message
    self.chat_1.jump_to_card_by_text(self.username_2)
../views/base_view.py:639: in jump_to_card_by_text
    self.click_on_floating_jump_to()
../views/base_view.py:628: in click_on_floating_jump_to
    self.jump_to_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `jump-to` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    7. test_1_1_chat_send_image_save_and_share, id: 703391

    Device 1: Find Button by accessibility id: jump-to 

    critical/chats/test_1_1_public_chats.py:1212: in test_1_1_chat_send_image_save_and_share
    self.chat_1.jump_to_card_by_text(self.username_2)
../views/base_view.py:639: in jump_to_card_by_text
    self.click_on_floating_jump_to()
../views/base_view.py:628: in click_on_floating_jump_to
    self.jump_to_button.click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `jump-to` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    8. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_mute_chat, id: 703495

    Device 2: UnreadMessagesCountText is 1
    Device 3: Sending message 'Chat is unmuted now' 

    critical/chats/test_group_chat.py:587: in test_group_chat_mute_chat
    self.chats[2].send_message(unmuted_message)
../views/chat_view.py:991: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `3`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297

    # STEP: Admin checks image message
    Device 1: Looking for a message by text: test image 

    critical/chats/test_group_chat.py:357: in test_group_chat_send_image_save_and_share
    self.chats[0].chat_element_by_text(image_description).wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'test image')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    4. test_group_chat_reactions, id: 703202

    # STEP: Admin sends a message
    Device 1: Sending message 'This is a test message to check some reactions.' 

    critical/chats/test_group_chat.py:239: in test_group_chat_reactions
    self.chats[0].send_message(message)
../views/chat_view.py:991: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Text is Delivered
    Device 1: Looking for a message by text: Hey, admin! 

    critical/chats/test_group_chat.py:231: in test_group_chat_join_send_text_messages_push
    self.errors.verify_no_errors()
base_test_case.py:187: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 No PN was received on new message for message in group chat
E    Message Hey, admin! was not received by admin; 
 RemoteDisconnected



    Device sessions

    6. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:441: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:187: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline



    Device sessions

    Passed tests (20)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_message_delete, id: 702839
    Device sessions

    6. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    9. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    3. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @J-Son89 thanx for the fix. Let's merge it.

    @J-Son89
    Copy link
    Contributor Author

    J-Son89 commented Sep 1, 2023

    @pavloburykh - sorry for delay, rebased and will merge now :)

    @J-Son89 J-Son89 merged commit 7245587 into develop Sep 1, 2023
    2 checks passed
    @J-Son89 J-Son89 deleted the jc/fix-pr branch September 1, 2023 12:11
    alwx pushed a commit that referenced this pull request Sep 6, 2023
    @J-Son89 @alwx
    fix: remove hole view code with error (#17164)
    2ea60e8
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @siddarthkay siddarthkay siddarthkay approved these changes

    @ajayesivan ajayesivan ajayesivan approved these changes

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    Assignees

    @J-Son89 J-Son89

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @J-Son89 @status-im-auto @pavloburykh @Parveshdhull @ajayesivan @siddarthkay