Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix show the hashtag in chat when replying/copying status-tag #17374

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix show the hashtag in chat when replying/copying status-tag #17374

merged 1 commit into from
Oct 3, 2023

Conversation

clauxx
Copy link
Member

@clauxx clauxx commented Sep 21, 2023

fixes #11161

Summary

Show the hashtag when the user copies and in the reply to a message containing a status-tag e.g. "#general". See screenshots below for the before and after versions respectively.

Testing notes

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • 1-1 chats
  • public chats
  • group chats

Steps to test

  • Open Status
  • Go to a community channel (or a 1-1 chat)
  • Send a message with a hashtag
  • Reply to it (the # should be visible in the reply)
  • Copy and paste it (the inserted text should include the #)

status: ready

@clauxx clauxx self-assigned this Sep 21, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Sep 21, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (20)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a4d4cd9 #1 2023-09-21 08:15:58 ~6 min android-e2e 🤖apk 📲
✔️ a4d4cd9 #1 2023-09-21 08:16:44 ~6 min ios 📱ipa 📲
✔️ a4d4cd9 #1 2023-09-21 08:19:54 ~10 min android 🤖apk 📲
✔️ a4d4cd9 #1 2023-09-21 08:21:23 ~11 min tests 📄log
✔️ 4697970 #2 2023-09-27 09:12:47 ~6 min android 🤖apk 📲
✔️ 4697970 #2 2023-09-27 09:12:55 ~6 min android-e2e 🤖apk 📲
✔️ 4697970 #2 2023-09-27 09:13:06 ~6 min ios 📱ipa 📲
✔️ 4697970 #2 2023-09-27 09:15:53 ~9 min tests 📄log
✔️ 6ca23ca #3 2023-09-27 09:43:07 ~6 min ios 📱ipa 📲
✔️ 6ca23ca #3 2023-09-27 09:43:14 ~6 min android-e2e 🤖apk 📲
✔️ 6ca23ca #3 2023-09-27 09:43:18 ~6 min android 🤖apk 📲
✔️ 6ca23ca #3 2023-09-27 09:49:39 ~12 min tests 📄log
✔️ 42f3dbb #4 2023-09-27 10:20:07 ~6 min android-e2e 🤖apk 📲
✔️ 42f3dbb #4 2023-09-27 10:20:12 ~6 min android 🤖apk 📲
✔️ 42f3dbb #4 2023-09-27 10:22:17 ~8 min tests 📄log
✔️ 42f3dbb #4 2023-09-27 10:25:56 ~12 min ios 📱ipa 📲
✔️ cb9d8ca #5 2023-09-29 10:18:14 ~5 min android-e2e 🤖apk 📲
✔️ cb9d8ca #5 2023-09-29 10:19:40 ~7 min ios 📱ipa 📲
✔️ cb9d8ca #5 2023-09-29 10:21:11 ~8 min android 🤖apk 📲
✔️ cb9d8ca #5 2023-09-29 10:22:44 ~10 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0049be2 #6 2023-10-03 07:45:54 ~6 min ios 📱ipa 📲
✔️ 0049be2 #6 2023-10-03 07:48:38 ~9 min android-e2e 🤖apk 📲
✔️ 0049be2 #6 2023-10-03 07:48:53 ~9 min android 🤖apk 📲
✔️ 0049be2 #6 2023-10-03 07:49:46 ~10 min tests 📄log
✔️ cf46f75 #9 2023-10-03 08:31:43 ~5 min android 🤖apk 📲
✔️ cf46f75 #9 2023-10-03 08:32:15 ~6 min android-e2e 🤖apk 📲
✔️ cf46f75 #9 2023-10-03 08:32:48 ~6 min ios 📱ipa 📲
✔️ cf46f75 #9 2023-10-03 08:35:31 ~9 min tests 📄log

ajayesivan
ajayesivan approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@ajayesivan ajayesivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@status-im-auto
Copy link
Member

37% of end-end tests have passed

Total executed tests: 43
Failed tests: 27
Passed tests: 16

IDs of failed tests: 702809,702782,702733,703194,702859,702732,702851,702840,703495,703086,702894,702745,702783,703297,703503,702936,702855,703202,702786,702947,702838,702844,702843,702731,702808,702730,702958

Failed tests (27)

Click to expand
  • Rerun failed tests

    • Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958

    ## Sign in (password:qwerty1234, keycard:False)
    Device 1: Find `EditBox` by `accessibility id`: `password-input` 

    medium/test_activity_center.py:377: in test_activity_center_admin_notification_accept_swipe
    self.home_1.reopen_app()
../views/base_view.py:651: in reopen_app
    sign_in_view.sign_in(password)
../views/sign_in_view.py:296: in sign_in
    self.password_input.send_keys(password)
../views/base_element.py:367: in send_keys
    self.find_element().send_keys(value)
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: EditBox by accessibility id: `password-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_mute_chat, id: 703495

    Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 2: Looking for a message by text: Chat is unmuted now 

    critical/chats/test_group_chat.py:606: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message text 'Text message in the muted chat' is not shown in chat preview after mute
E    Message 'Text message in the muted chat' is not shown in chat for member_1 after mute



    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297

    # STEP: Member_2 checks image message
    Device 3: Looking for a message by text: test image 

    critical/chats/test_group_chat.py:363: in test_group_chat_send_image_save_and_share
    self.chats[2].chat_element_by_text(image_description).wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 3: ChatElementByText by xpath:`//*[starts-with(@text,'test image')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    4. test_group_chat_reactions, id: 703202

    Device 2: Looking for a message by text: This is a test message to check some reactions.
    Device 2: Find ChatElementByText by xpath: //*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item'] 

    critical/chats/test_group_chat.py:242: in test_group_chat_reactions
    self.chats[1].set_reaction(message=message, emoji="thumbs-up")
../views/chat_view.py:1064: in set_reaction
    self.chat_element_by_text(message).long_press_until_element_is_shown(element)
../views/base_element.py:317: in long_press_until_element_is_shown
    element = self.find_element()
../views/chat_view.py:134: in find_element
    self.wait_for_visibility_of_element(20)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    5. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:442: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline
E    message from old member if not shown for device 0
E    message from new member if not shown for device 0
E    message from new member if not shown for device 1



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Delivered 

    critical/chats/test_1_1_public_chats.py:1416: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message was not delivered after resending from offline



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

    Device 1: Wait for text element EmojisNumber to be equal to 1
    Device 1: Find EmojisNumber by xpath: //*[starts-with(@text,'Test with link: https://status.im/ here should be nothing unusual.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView 

    critical/chats/test_1_1_public_chats.py:973: in test_1_1_chat_emoji_send_reply_and_open_link
    self.chat_1.chat_element_by_text(url_message).emojis_below_message().wait_for_element_text(1)
../views/base_element.py:172: in wait_for_element_text
    element_text = self.find_element().text.strip()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: EmojisNumber by xpath: `//*[starts-with(@text,'Test with link: https://status.im/ here should be nothing unusual.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733

    Device 2: Find Text by xpath: //*[starts-with(@text,'smth I should edit')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:1280: in test_1_1_chat_text_message_delete_push_disappear
    self.chat_2.chat_element_by_text(message_after_edit_1_1).wait_for_status_to_be("Delivered")
../views/chat_view.py:235: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent



    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Find MemberPhoto by xpath: //*[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='user-avatar']
    Device 2: Image differs from template to 5.760426240808823 percents 

    critical/chats/test_1_1_public_chats.py:1128: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message with text 'hello' was not received
E    Message with text '¿Cómo estás tu año?' was not received



    Device sessions

    4. test_1_1_chat_edit_message, id: 702855

    Device 2: Find Text by xpath: //*[starts-with(@text,'Message before edit 1-1')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:1192: in test_1_1_chat_edit_message
    self.chat_2.chat_element_by_text(message_before_edit_1_1).wait_for_status_to_be("Delivered")
../views/chat_view.py:235: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent



    Device sessions

    5. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    6. test_1_1_chat_message_reaction, id: 702730

    Device 1: Wait for text element EmojisNumber to be equal to 1
    Device 1: Find EmojisNumber by xpath: //*[starts-with(@text,'Message sender')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-1']/android.widget.TextView 

    critical/chats/test_1_1_public_chats.py:894: in test_1_1_chat_message_reaction
    message_sender.emojis_below_message(emoji="love").wait_for_element_text(1, 90)
../views/base_element.py:172: in wait_for_element_text
    element_text = self.find_element().text.strip()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: EmojisNumber by xpath: `//*[starts-with(@text,'Message sender')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-1']/android.widget.TextView` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 1: Find ChatsTab by accessibility id: chats-stack-tab
    Device 1: Tap on found: ChatsTab 

    medium/test_activity_center.py:102: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.home_1.notifications_unread_badge.wait_for_visibility_of_element(30)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: BaseElement by accessibility id:`activity-center-unread-count` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936

    Device 2: Find Button by xpath: //*[@content-desc='password-input']/../following-sibling::*//*[@text='Join Community']
    Device 2: Tap on found: Button 

    Test setup failed: medium/test_activity_center.py:176: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:424: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 

    Test setup failed: medium/test_activity_center.py:176: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:424: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809

    Device 1: Looking for a message by text: quote reply (one row)
    Device 2: Looking for a message by text: quote reply (one row) 

    critical/test_public_chat_browsing.py:1201: in test_community_markdown_support
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 bold text in asterics is not displayed with markdown in 1-1 chat for the recipient (device 2) 
E   
E    bold text in underscores is not displayed with markdown in 1-1 chat for the recipient (device 2)



    Device sessions

    2. test_community_mentions_push_notification, id: 702786

    # STEP: Invited member gets push notification with the mention and tap it
    Device 2: Getting PN by 'user_2' 

    critical/test_public_chat_browsing.py:1149: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin
E    Can not edit a message with a mention
E    Push notification with the mention was not received by the invited member

    [[Issue with username in PN, issue #6 in 15500]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] https://github.com//issues/17175]]

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194

    Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 2: Looking for a message by text: gallery 

    critical/test_public_chat_browsing.py:686: in test_community_several_images_send_reply
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Gallery message was not received



    Device sessions

    2. test_community_one_image_send_reply, id: 702859

    Device 2: Looking for a message by text: description
    Device 2: Looking for a message by text: description 

    critical/test_public_chat_browsing.py:697: in test_community_one_image_send_reply
    self.channel_2.chat_element_by_text(image_description).wait_for_visibility_of_element(10)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'description')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840

    Device 2: Quoting '🏄🏻‍♂️' message
    Device 2: Find BaseElement by xpath: //*[@content-desc=':chat-floating-screen']//*[starts-with(@text,'🏄🏻‍♂️')] 

    critical/test_public_chat_browsing.py:778: in test_community_emoji_send_copy_paste_reply
    self.channel_2.quote_message(emoji_unicode)
../views/chat_view.py:1052: in quote_message
    self.chat_view_element_starts_with_text(message).long_press_until_element_is_shown(self.reply_message_button)
../views/base_element.py:317: in long_press_until_element_is_shown
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: BaseElement by xpath: `//*[@content-desc=':chat-floating-screen']//*[starts-with(@text,'🏄🏻‍♂️')]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086

    Device 1: Tap on found: Button
    Device 1: Click until Text by accessibility id: community-description-text will be presented 

    critical/test_public_chat_browsing.py:1028: in test_community_mark_all_messages_as_read
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter is not shown in home > Community element
E    New messages counter is not shown in community channel element



    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
    Device 1: Looking for a message by text: Hurray! unblocked 

    critical/test_public_chat_browsing.py:967: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Hurray! unblocked was not received in public chat after user unblock!

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    Device sessions

    6. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'new message' is under today
    Device 2: Looking for a message by text: new message 

    critical/test_public_chat_browsing.py:597: in test_community_message_send_check_timestamps_sender_username
    self.channel_2.verify_message_is_under_today_text(new_message, self.errors, 60)
../views/chat_view.py:985: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element(timeout)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'new message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

    Device 2: Wait for text element EmojisNumber to be equal to 1
    Device 2: Find EmojisNumber by xpath: //*[starts-with(@text,'https://m.youtube.com/watch?v=Je7yErjEVt4')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-4']/android.widget.TextView 

    critical/test_public_chat_browsing.py:867: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Link message reaction is not shown for the sender



    Device sessions

    8. test_community_message_edit, id: 702843

    Device 2: Looking for a message by text: Message AFTER edit 2 (Edited)
    Device 2: Find ChatElementByText by xpath: //*[starts-with(@text,'Message AFTER edit 2 (Edited)')]/ancestor::android.view.ViewGroup[@content-desc='chat-item'] 

    critical/test_public_chat_browsing.py:611: in test_community_message_edit
    self.channel_2.set_reaction(message_text_after_edit)
../views/chat_view.py:1064: in set_reaction
    self.chat_element_by_text(message).long_press_until_element_is_shown(element)
../views/base_element.py:317: in long_press_until_element_is_shown
    element = self.find_element()
../views/chat_view.py:134: in find_element
    self.wait_for_visibility_of_element(20)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'Message AFTER edit 2 (Edited)')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Passed tests (16)

    Click to expand

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    2. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    2. test_community_leave, id: 702845
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_delete, id: 702839
    Device sessions

    2. test_community_unread_messages_badge, id: 702841
    Device sessions

    @qoqobolo qoqobolo self-assigned this Sep 26, 2023
    @qoqobolo
    Copy link
    Contributor

    Thanks for the fix @clauxx, LGTM.
    PR can be merged.

    @clauxx
    Copy link
    Member Author

    clauxx commented Sep 27, 2023

    Thanks for the fix @clauxx, LGTM. PR can be merged.

    Does it need a design check?

    @qoqobolo
    Copy link
    Contributor

    Does it need a design check?

    hmm this is such a small change.. Although let’s ask to take a look at this just in case, you're right.
    @Francesca-G could you check, please?

    Francesca-G
    Francesca-G approved these changes Sep 27, 2023
    View reviewed changes
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    seems to work for me ✨

    @clauxx clauxx force-pushed the 11161-fix-hashtag-reply-copy branch from dc266ad to adb4de6 Compare October 3, 2023 08:24
    @clauxx clauxx requested a review from jakubgs as a code owner October 3, 2023 08:24
    @clauxx clauxx force-pushed the 11161-fix-hashtag-reply-copy branch from adb4de6 to cf46f75 Compare October 3, 2023 08:25
    @clauxx clauxx merged commit dfc9720 into develop Oct 3, 2023
    6 checks passed
    @clauxx clauxx deleted the 11161-fix-hashtag-reply-copy branch October 3, 2023 08:55
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Francesca-G Francesca-G Francesca-G approved these changes

    @ajayesivan ajayesivan ajayesivan approved these changes

    @cammellos cammellos Awaiting requested review from cammellos

    @FFFra FFFra Awaiting requested review from FFFra

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    @jakubgs jakubgs Awaiting requested review from jakubgs

    Assignees

    @clauxx clauxx

    @qoqobolo qoqobolo

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Hashtag symbol is cut from messages when replying or copying (only plain text is shown)
    5 participants
    @clauxx @status-im-auto @qoqobolo @ajayesivan @Francesca-G