Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all status-im.ui.components.react usages in status-im2 #17750

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Remove all status-im.ui.components.react usages in status-im2 #17750

merged 1 commit into from
Oct 30, 2023

Conversation

ajayesivan
Copy link
Contributor

fixes #17277

status: ready

@ajayesivan ajayesivan self-assigned this Oct 27, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Oct 27, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2eda93c #1 2023-10-27 08:28:55 ~5 min android 🤖apk 📲
✔️ 2eda93c #1 2023-10-27 08:31:13 ~8 min android-e2e 🤖apk 📲
✔️ 2eda93c #1 2023-10-27 08:32:57 ~9 min ios 📱ipa 📲
✔️ 2eda93c #1 2023-10-27 08:32:59 ~9 min tests 📄log
✔️ 157aef3 #2 2023-10-30 13:05:31 ~6 min android 🤖apk 📲
✔️ 157aef3 #2 2023-10-30 13:05:41 ~6 min android-e2e 🤖apk 📲
✔️ 157aef3 #2 2023-10-30 13:11:08 ~11 min tests 📄log
✔️ 157aef3 #2 2023-10-30 13:18:00 ~18 min ios 📱ipa 📲

clauxx
clauxx approved these changes Oct 27, 2023
View reviewed changes
src/status_im2/contexts/communities/discover/view.cljs Outdated
Comment on lines 120 to 119
[react/animated-view
[rn/animated-view
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but is this animated view needed here? Seems to have no animated styles.

@status-im-auto
Copy link
Member

87% of end-end tests have passed

Total executed tests: 45
Failed tests: 3
Expected to fail tests: 3
Passed tests: 39

IDs of failed tests: 702786,702807,702813 

IDs of expected to fail tests: 702732,702731,702808

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813

    Device 1: App to background
    Device 2: Sending message 'emoji' 

    critical/chats/test_1_1_public_chats.py:345: in test_1_1_chat_push_emoji
    chat_2.send_message(emoji.emojize(emoji_message))
../views/chat_view.py:1000: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Text is Delivered
    Device 1: Looking for a message by text: Hey, admin! 

    critical/chats/test_group_chat.py:97: in test_group_chat_join_send_text_messages_push
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message Hey, admin! was not received by admin



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    Device 2: Getting PN by 'user_2'
    Device 2: Looking for a message by text: user_2 

    critical/chats/test_public_chat_browsing.py:882: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Channel did not open by clicking on a notification with the mention for admin
E    Edited message is not shown correctly for the sender
E    Edited message is not shown correctly for the (receiver) admin
E    Channel did not open by clicking on a notification with the mention for the invited member



    Device sessions

    Expected to fail tests (3)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:309: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Passed tests (39)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    2. test_community_unread_messages_badge, id: 702841
    Device sessions

    3. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    4. test_community_one_image_send_reply, id: 702859
    Device sessions

    5. test_community_several_images_send_reply, id: 703194
    Device sessions

    6. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    7. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_delete, id: 702839
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    2. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    3. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    6. test_1_1_chat_edit_message, id: 702855
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    2. test_community_markdown_support, id: 702809
    Device sessions

    3. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    3. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    3. test_community_mute_community_and_channel, id: 703382
    Device sessions

    4. test_community_discovery, id: 703503
    Device sessions

    5. test_community_undo_delete_message, id: 702869
    Device sessions

    6. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    J-Son89
    J-Son89 approved these changes Oct 27, 2023
    View reviewed changes
    Copy link
    Contributor

    @J-Son89 J-Son89 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    good stuff @ajayesivan !! 💪

    @churik
    Copy link
    Member

    churik commented Oct 27, 2023

    Failed tests are expected, so if no manual testing is required, it is ready to go

    @ajayesivan ajayesivan force-pushed the 17277-migrate-old-ui-code-remove-react branch from 2eda93c to 157aef3 Compare October 30, 2023 12:59
    @ajayesivan ajayesivan merged commit abbf29d into develop Oct 30, 2023
    6 checks passed
    @ajayesivan ajayesivan deleted the 17277-migrate-old-ui-code-remove-react branch October 30, 2023 13:37
    yqrashawn pushed a commit that referenced this pull request Oct 30, 2023
    @ajayesivan @yqrashawn
    Remove all status-im.ui.components.react usages in status-im2 (#17750)
    5064e31
    yevh-berdnyk pushed a commit that referenced this pull request Dec 8, 2023
    @ajayesivan @yevh-berdnyk
    Remove all status-im.ui.components.react usages in status-im2 (#17750)
    dbb2ac7
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ilmotta ilmotta ilmotta approved these changes

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @clauxx clauxx clauxx approved these changes

    @J-Son89 J-Son89 J-Son89 approved these changes

    @flexsurfer flexsurfer Awaiting requested review from flexsurfer

    @jo-mut jo-mut Awaiting requested review from jo-mut

    Assignees

    @ajayesivan ajayesivan

    Labels
    None yet
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Replace status-im.ui.components.react in status-im2
    7 participants
    @ajayesivan @status-im-auto @churik @ilmotta @Parveshdhull @clauxx @J-Son89