fix: Marking AC notification as read does not affect correspondent me… #18058

qfrank · 2023-12-04T10:20:42Z

status: ready

status-im-auto · 2023-12-04T10:27:55Z

Jenkins Builds

Click to see older builds (12)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`3d399b5`	#1	2023-12-04 10:27:54	~6 min	`android`	🤖`apk` 📲
✔️	`3d399b5`	#1	2023-12-04 10:28:05	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`3d399b5`	#1	2023-12-04 10:32:22	~11 min	`tests`	📄`log`
✔️	`3d399b5`	#1	2023-12-04 10:35:11	~14 min	`ios`	📱`ipa` 📲

✔️	`860b58d`	#2	2023-12-05 11:23:47	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`860b58d`	#2	2023-12-05 11:28:56	~11 min	`android`	🤖`apk` 📲
✔️	`860b58d`	#2	2023-12-05 11:29:45	~12 min	`ios`	📱`ipa` 📲
✔️	`860b58d`	#2	2023-12-05 11:29:57	~12 min	`tests`	📄`log`

✔️	`d6d5f8e`	#3	2023-12-06 02:10:24	~6 min	`android`	🤖`apk` 📲
✔️	`d6d5f8e`	#3	2023-12-06 02:10:46	~6 min	`ios`	📱`ipa` 📲
✔️	`d6d5f8e`	#3	2023-12-06 02:12:22	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`d6d5f8e`	#3	2023-12-06 02:15:03	~10 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`2f54c9e`	#4	2023-12-06 08:54:43	~3 min	`tests`	📄`log`
✔️	`2f54c9e`	#4	2023-12-06 08:58:16	~6 min	`ios`	📱`ipa` 📲
✔️	`2f54c9e`	#4	2023-12-06 08:58:18	~6 min	`android`	🤖`apk` 📲
✔️	`2f54c9e`	#4	2023-12-06 08:58:27	~6 min	`android-e2e`	🤖`apk` 📲

✔️	`ca5d998`	#5	2023-12-07 02:11:28	~6 min	`ios`	📱`ipa` 📲
✔️	`ca5d998`	#5	2023-12-07 02:11:32	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`ca5d998`	#5	2023-12-07 02:11:50	~6 min	`android`	🤖`apk` 📲
✔️	`ca5d998`	#5	2023-12-07 02:15:33	~10 min	`tests`	📄`log`

src/status_im/chat/models/loading.cljs

src/status_im2/contexts/shell/activity_center/events.cljs

status-im-auto · 2023-12-05T17:03:17Z

54% of end-end tests have passed

Total executed tests: 48
Failed tests: 19
Expected to fail tests: 3
Passed tests: 26

IDs of failed tests: 702809,702782,702733,702813,703133,702957,703495,702745,703297,704614,702855,703202,703391,702786,702846,702807,702808,702730,702958

IDs of expected to fail tests: 702732,703503,702731

Failed tests (19)

Click to expand

Rerun failed tests

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
Test setup failed: base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id' During handling of the above exception, another exception occurred: critical/chats/test_group_chat.py:18: in prepare_devices self.drivers, self.loop = create_shared_drivers(3) base_test_case.py:322: in create_shared_drivers test_suite_data.current_test.testruns[-1].error += str(e) E TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'
2. test_group_chat_send_image_save_and_share, id: 703297
Test setup failed: base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id' During handling of the above exception, another exception occurred: critical/chats/test_group_chat.py:18: in prepare_devices self.drivers, self.loop = create_shared_drivers(3) base_test_case.py:322: in create_shared_drivers test_suite_data.current_test.testruns[-1].error += str(e) E TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'
3. test_group_chat_reactions, id: 703202
Test setup failed: base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id' During handling of the above exception, another exception occurred: critical/chats/test_group_chat.py:18: in prepare_devices self.drivers, self.loop = create_shared_drivers(3) base_test_case.py:322: in create_shared_drivers test_suite_data.current_test.testruns[-1].error += str(e) E TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'
4. test_group_chat_join_send_text_messages_push, id: 702807
Test setup failed: base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id' During handling of the above exception, another exception occurred: critical/chats/test_group_chat.py:18: in prepare_devices self.drivers, self.loop = create_shared_drivers(3) base_test_case.py:322: in create_shared_drivers test_suite_data.current_test.testruns[-1].error += str(e) E TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'
5. test_group_chat_offline_pn, id: 702808
Test setup failed: base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id' During handling of the above exception, another exception occurred: critical/chats/test_group_chat.py:18: in prepare_devices self.drivers, self.loop = create_shared_drivers(3) base_test_case.py:322: in create_shared_drivers test_suite_data.current_test.testruns[-1].error += str(e) E TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str' [[Data delivery issue]]

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device 1: Find `Button` by `accessibility id`: `show-profiles` Device 1: Tap on found: Button `critical/chats/test_public_chat_browsing.py:273: in test_restore_multiaccount_with_waku_backup_remove_switch self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Incorrect contacts number restored: 3 instead of 2` Device sessions Device 1: Steps, video, logs Failure screenshot
2. test_community_navigate_to_channel_when_relaunch, id: 702846
## Signed in successfully! Device 1: Looking for a message by text: some_text `critical/chats/test_public_chat_browsing.py:83: in test_community_navigate_to_channel_when_relaunch self.drivers[0].fail("Not navigated to channel view after reopening app") base_test_case.py:179: in fail pytest.fail('Device %s: %s' % (self.number, text)) Device 1: Not navigated to channel view after reopening app` Device sessions Device 1: Steps, video, logs Failure screenshot

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_other_apps, id: 704614

Device 1: Tap on found: Button
Device 1: Wait for element Button for max 30s and click when it is available

critical/test_deep_and_universal_links.py:119: in test_links_open_universal_links_from_other_apps
    self.sign_in.create_user()
../views/sign_in_view.py:249: in create_user
    self.identifiers_button.wait_and_click(30)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Button by accessibility id:`skip-identifiers` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Test setup failed: base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id' During handling of the above exception, another exception occurred: critical/chats/test_1_1_public_chats.py:18: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:322: in create_shared_drivers test_suite_data.current_test.testruns[-1].error += str(e) E TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Test setup failed: base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id' During handling of the above exception, another exception occurred: critical/chats/test_1_1_public_chats.py:18: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:322: in create_shared_drivers test_suite_data.current_test.testruns[-1].error += str(e) E TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'
3. test_1_1_chat_push_emoji, id: 702813
Test setup failed: base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id' During handling of the above exception, another exception occurred: critical/chats/test_1_1_public_chats.py:18: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:322: in create_shared_drivers test_suite_data.current_test.testruns[-1].error += str(e) E TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Test setup failed: base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id' During handling of the above exception, another exception occurred: critical/chats/test_1_1_public_chats.py:18: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:322: in create_shared_drivers test_suite_data.current_test.testruns[-1].error += str(e) E TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'
5. test_1_1_chat_edit_message, id: 702855
Test setup failed: base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id' During handling of the above exception, another exception occurred: critical/chats/test_1_1_public_chats.py:18: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:322: in create_shared_drivers test_suite_data.current_test.testruns[-1].error += str(e) E TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'
6. test_1_1_chat_send_image_save_and_share, id: 703391
Test setup failed: base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id' During handling of the above exception, another exception occurred: critical/chats/test_1_1_public_chats.py:18: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:322: in create_shared_drivers test_suite_data.current_test.testruns[-1].error += str(e) E TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'
7. test_1_1_chat_message_reaction, id: 702730
Test setup failed: base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id' During handling of the above exception, another exception occurred: critical/chats/test_1_1_public_chats.py:18: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:322: in create_shared_drivers test_suite_data.current_test.testruns[-1].error += str(e) E TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str' Device sessions Device 1: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device 1: Looking for a message by text: quote reply (one row) Device 2: Looking for a message by text: quote reply (one row) `critical/chats/test_public_chat_browsing.py:953: in test_community_markdown_support self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) quote reply (one row) is not displayed with markdown in community channel for the recipient (device 1)` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_mentions_push_notification, id: 702786
Device 2: Getting PN by 'user_2' Device 2: Looking for a message by text: user_2 `critical/chats/test_public_chat_browsing.py:901: in test_community_mentions_push_notification self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Can not edit a message with a mention E Edited message is not shown correctly for the (receiver) admin` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device 2: Looking for a message by text: open community Device 2: Find `BaseElement` by `xpath`: `//[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@text='View']` Test setup failed: activity_center/test_activity_center.py:396: in prepare_devices self.chat_2.chat_element_by_text(self.community_name).view_community_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: BaseElement by xpath: `//[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Test setup failed: activity_center/test_activity_center.py:396: in prepare_devices self.chat_2.chat_element_by_text(self.community_name).view_community_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: BaseElement by xpath: `//[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Expected to fail tests (3)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Passed tests (26)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
3. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2023-12-06T08:15:06Z

79% of end-end tests have passed

Total executed tests: 48
Failed tests: 4
Expected to fail tests: 6
Passed tests: 38

IDs of failed tests: 702948,703629,703133,702782

IDs of expected to fail tests: 702894,702731,702808,702846,702732,703503

Failed tests (4)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

Device 2: Find `OpenInStatusButton` by `xpath`: `//*[@text="Open in Status"]`
Device 2: Tap on found: OpenInStatusButton

critical/chats/test_1_1_public_chats.py:174: in test_1_1_chat_emoji_send_reply_and_open_link
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Reply for 'Test with link: https://status.im/ here should be nothing unusual.' not present in message received in public chat

Device sessions

Device 1:

Device 2:

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_hashtag_links_to_community_channels, id: 702948
Device 2: ChatMessageInput element not found Device 2: Looking for a message by text: #cats critical/chats/test_public_chat_browsing.py:1018: in test_community_hashtag_links_to_community_channels self.channel_2.chat_element_by_text(message_with_hashtag).click_on_link_inside_message_body() ../views/chat_view.py:193: in click_on_link_inside_message_body self.message_body.wait_for_visibility_of_element(30) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]` is not found on the screen after wait_for_visibility_of_element; RemoteDisconnected Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_join_when_node_owner_offline, id: 703629
Device 2: Looking for a message by text: open community Device 2: Find `BaseElement` by `xpath`: `//[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@text='View']` critical/chats/test_public_chat_browsing.py:1069: in test_community_join_when_node_owner_offline self.chat_2.chat_element_by_text(community_name).view_community_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: BaseElement by xpath: `//[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device 1: Find Button by accessibility id: show-profiles
Device 1: Tap on found: Button

critical/chats/test_public_chat_browsing.py:274: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Incorrect contacts number restored: 3 instead of 2

Device sessions

Device 1:

Expected to fail tests (6)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_offline_pn, id: 702808
Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member `critical/chats/test_group_chat.py:323: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Messages PN was not fetched from offline` [[Data delivery issue]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
2. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestCommunityMultipleDeviceMerged:

1. test_community_contact_block_unblock_offline, id: 702894
Device 1: Find `ProfileSendMessageButton` by `accessibility id`: `Chat-item-button` Device 1: Sending message 'piy' `critical/chats/test_public_chat_browsing.py:741: in test_community_contact_block_unblock_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Chat with unblocked user was not enabled after 1 minute` [[Message can be missed after unblock: https://github.com//issues/16873]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityOneDeviceMerged:

1. test_community_navigate_to_channel_when_relaunch, id: 702846
`Test is not run, e2e blocker` [[reason: [NOTRUN] Issue #18075]]
2. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (38)

Click to expand

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
3. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs
2. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
3. test_links_open_universal_links_from_other_apps, id: 704614
Device sessions Device 1: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

churik · 2023-12-06T13:46:14Z

@qfrank thank you for PR!

There is still an issue if instead of "Making notification as read" we are using "Mark All notification as read"

FILE.2023-12-06.14.45.20.mp4

It can be fixed separately, as there are some cases with several communities, unread CRs, etc.

What do you think?

qfrank · 2023-12-06T13:49:02Z

let me fix it separately, could you help creating separate issue to track? thank you @churik

…ssage in chat

…ssage in chat (#18058)

qfrank added the request-manual-qa label Dec 4, 2023

qfrank requested review from ilmotta and vkjr December 4, 2023 10:20

qfrank self-assigned this Dec 4, 2023

ilmotta reviewed Dec 4, 2023

View reviewed changes

src/status_im/chat/models/loading.cljs Outdated Show resolved Hide resolved

src/status_im2/contexts/shell/activity_center/events.cljs Outdated Show resolved Hide resolved

qfrank force-pushed the fix/18050 branch from 3d399b5 to 860b58d Compare December 5, 2023 11:17

ilmotta approved these changes Dec 5, 2023

View reviewed changes

qfrank force-pushed the fix/18050 branch from 860b58d to d6d5f8e Compare December 6, 2023 02:03

pavloburykh force-pushed the fix/18050 branch from d6d5f8e to 2f54c9e Compare December 6, 2023 08:51

churik self-assigned this Dec 6, 2023

churik mentioned this pull request Dec 6, 2023

"Making notification as read" doesn't erase them in unread counters #18098

Closed

churik added Tested - OK and removed request-manual-qa labels Dec 6, 2023

fix: Marking AC notification as read does not affect correspondent me…

ca5d998

…ssage in chat

qfrank force-pushed the fix/18050 branch from 2f54c9e to ca5d998 Compare December 7, 2023 02:04

qfrank merged commit aa89ebd into develop Dec 7, 2023
6 checks passed

qfrank deleted the fix/18050 branch December 7, 2023 02:16

yevh-berdnyk pushed a commit that referenced this pull request Dec 8, 2023

fix: Marking AC notification as read does not affect correspondent me…

c2de6de

…ssage in chat (#18058)

fix: Marking AC notification as read does not affect correspondent me… #18058

fix: Marking AC notification as read does not affect correspondent me… #18058

Conversation

qfrank commented Dec 4, 2023

status-im-auto commented Dec 4, 2023 • edited Loading

Jenkins Builds

status-im-auto commented Dec 5, 2023

54% of end-end tests have passed

Failed tests (19)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestDeepLinksOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePRTwo:

Expected to fail tests (3)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Passed tests (26)

Class TestCommunityOneDeviceMerged:

Class TestDeepLinksOneDevice:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

status-im-auto commented Dec 6, 2023

79% of end-end tests have passed

Failed tests (4)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityOneDeviceMerged:

Expected to fail tests (6)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Passed tests (38)

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestDeepLinksOneDevice:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePRTwo:

churik commented Dec 6, 2023

qfrank commented Dec 6, 2023 • edited Loading

status-im-auto commented Dec 4, 2023 •

edited

Loading

qfrank commented Dec 6, 2023 •

edited

Loading