Activity tab on collectible page #18220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we check with designs how we want this to look? perhaps there's a max length on the sub title/description 
|
Jenkins BuildsClick to see older builds (13)
|
J-Son89
requested review from
shivekkhurana,
smohamedjavid,
ulisesmac and
mmilad75
|
Hi @vkjr. I've been working on the same page on the About tab. I followed a different approach for structuring the codes. You can see my branch which is not finished yet btw here cc @J-Son89 |
ulisesmac
approved these changes
Dec 18, 2023
| {:id :about | ||
| :label (i18n/label :t/about) | ||
| :accessibility-label :about-tab}]}]) | ||
| (def tabs-data |
There was a problem hiding this comment.
Cool you managed to change a defn to a def 👍
| [info chain-id] | ||
| [traits-section traits]] | ||
| :activity [activity-section] | ||
| [rn/view])]))) |
There was a problem hiding this comment.
Isn't it just the same as just returning nil?
There was a problem hiding this comment.
Why do we have an empty view here? Either we should return something or not 🤔
There was a problem hiding this comment.
Yeah, I think nil should be good)
| :style style/tabs | ||
| :scrollable? true | ||
| :default-active @selected-tab | ||
| :data tabs-data |
There was a problem hiding this comment.
Maybe instead of calling them tabs-data we can give a name more related to what kind of tabs they are, e.g. activity-tabs or something like that. wdyt?
There was a problem hiding this comment.
Sure, that would be more convenient for global search!
| :type :network | ||
| :network-logo (quo.resources/get-network :ethereum) | ||
| :network-name "Mainnet"} | ||
| } |
@J-Son89, it is my mistake. In the heading should be the name of the collection, not the description. Probably I messed that after |
vkjr
force-pushed
the
collectible-activity
branch
from
fb8cd50
to
8f902f2
Compare
vkjr
force-pushed
the
collectible-activity
branch
from
8f902f2
to
b0d08d5
Compare
56% of end-end tests have passedFailed tests (17)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Passed tests (27)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
|
smohamedjavid
approved these changes
Dec 19, 2023
88% of end-end tests have passedFailed tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Expected to fail tests (5)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (42)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
|
@vkjr thanx for the PR. e2e are okay! Ready for merge if no manual qa required. |
vkjr
force-pushed
the
collectible-activity
branch
2 times, most recently
from
92ff4df
to
62c2179
Compare
vkjr
force-pushed
the
collectible-activity
branch
from
62c2179
to
46a44f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17317
Summary
This PR implements activity tab on collectible page. So far with mock data.
Figma designs
status: ready