[Wallet]Fraschetti/Temporarily hide Activity Tab on Collectible Detail Page #19447

FFFra · 2024-03-28T17:07:55Z

fixes #19400

Summary

This pull request introduces a configuration option to conditionally incorporate the 'Activity' tab within the Collectibles Detail Page, facilitating ongoing development related to this feature. This option is intended for interim use and will be removed upon the completion of the feature's implementation.

Platforms

Android
iOS

Areas that maybe impacted

Wallet
Collectibles

Functional

Wallet
Transactions

Steps to test

Under status-im.config change wallet-collectible-actvity-enabled? to true or false
Navigate to Wallet->Collectibles

Before and after screenshots comparison

Before

After

status: ready!

status-im-auto · 2024-03-28T17:12:55Z

Jenkins Builds

Click to see older builds (11)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`9bbe9ec`	#1	2024-03-28 17:12:55	~4 min	`tests`	📄`log`
✔️	`9bbe9ec`	#1	2024-03-28 17:15:44	~7 min	`android`	🤖`apk` 📲
✔️	`9bbe9ec`	#1	2024-03-28 17:16:24	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`9bbe9ec`	#1	2024-03-28 17:19:40	~11 min	`ios`	📱`ipa` 📲

✔️	`29f15c7`	#3	2024-04-02 11:08:56	~4 min	`tests`	📄`log`
✔️	`29f15c7`	#3	2024-04-02 11:11:44	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`29f15c7`	#3	2024-04-02 11:13:48	~9 min	`android`	🤖`apk` 📲
✔️	`29f15c7`	#3	2024-04-02 11:18:30	~14 min	`ios`	📱`ipa` 📲

✔️	`674556d`	#4	2024-04-02 12:41:25	~6 min	`android`	🤖`apk` 📲
✔️	`674556d`	#4	2024-04-02 12:41:51	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`674556d`	#4	2024-04-02 12:45:38	~11 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`c33c98b`	#5	2024-04-02 13:39:26	~6 min	`android`	🤖`apk` 📲
✔️	`c33c98b`	#5	2024-04-02 13:40:07	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`c33c98b`	#5	2024-04-02 13:46:41	~13 min	`ios`	📱`ipa` 📲

✔️	`e42b307`	#6	2024-04-02 14:02:35	~4 min	`tests`	📄`log`
✔️	`e42b307`	#6	2024-04-02 14:04:12	~5 min	`android`	🤖`apk` 📲
✔️	`e42b307`	#6	2024-04-02 14:05:27	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`e42b307`	#6	2024-04-02 14:06:54	~8 min	`ios`	📱`ipa` 📲

J-Son89 · 2024-03-28T17:33:10Z

src/status_im/config.cljs

@@ -170,3 +170,4 @@
 (def community-accounts-selection-enabled? true)
 (def fetch-messages-enabled? (enabled? (get-config :FETCH_MESSAGES_ENABLED "1")))
 (def test-networks-enabled? (enabled? (get-config :TEST_NETWORKS_ENABLED "0")))
+(def wallet-collectible-actvity-enabled? false)


we have feature flags in a name space btw
src/status_im/feature_flags.cljs

then there's a ui in the settings to turn them on/off

J-Son89 · 2024-03-28T17:33:37Z

src/status_im/contexts/wallet/collectible/view.cljs

+        activity-tab [{:id                  :activity
+                       :label               (i18n/label :t/activity)
+                       :accessibility-label :activity-tab}]]
+    (concat base-tabs (if config/wallet-collectible-actvity-enabled? activity-tab []))))


tbh I don't think we need this. Let's just delete the activity tab for now and keep it simple 👍

J-Son89 · 2024-03-28T17:34:07Z

I think this can skip manual QA 👍

FFFra · 2024-04-02T11:03:37Z

Thanks guys! Let me know if there are more changes

status-im-auto · 2024-04-02T12:07:01Z

94% of end-end tests have passed

Total executed tests: 48
Failed tests: 2
Expected to fail tests: 1
Passed tests: 45

IDs of failed tests: 702782,702777

IDs of expected to fail tests: 703503

Failed tests (2)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device 2: Find `OpenInStatusButton` by `xpath`: `//*[@text="Open in Status"]` Device 2: Tap on found: OpenInStatusButton `critical/chats/test_1_1_public_chats.py:178: in test_1_1_chat_emoji_send_reply_and_open_link self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) No reply received in 1-1 chat` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777

Device 1: Find Button by xpath: //*[@text="Paste"]
Device 1: Tap on found: Button

activity_center/test_activity_center.py:237: in test_add_contact_field_validation
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Error message is not shown for value "random string 123"

Device sessions

Device 1:

Device 2:

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (45)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
6. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

pavloburykh · 2024-04-02T12:32:27Z

@FFFra e2e fails are not PR related.

FFFra added the E:Mobile Wallet MVP label Mar 28, 2024

FFFra requested review from vkjr and J-Son89 March 28, 2024 17:07

FFFra self-assigned this Mar 28, 2024

FFFra linked an issue Mar 28, 2024 that may be closed by this pull request

[Wallet] Temporarily Hide Activity Tab on Collectible Detail Page #19400

Closed

FFFra requested review from OmarBasem and briansztamfater March 28, 2024 17:08

FFFra requested a review from ulisesmac March 28, 2024 17:17

J-Son89 reviewed Mar 28, 2024

View reviewed changes

J-Son89 approved these changes Mar 28, 2024

View reviewed changes

ulisesmac approved these changes Apr 1, 2024

View reviewed changes

FFFra force-pushed the fraschetti/wallet-temporarily-hide-activity-tab-on-collectible-detail-page branch from 9bbe9ec to abb4d74 Compare April 2, 2024 11:02

FFFra added the skip-manual-qa label Apr 2, 2024

FFFra force-pushed the fraschetti/wallet-temporarily-hide-activity-tab-on-collectible-detail-page branch from abb4d74 to 29f15c7 Compare April 2, 2024 11:04

introduce feature flag for collectibles activity tab

6bd645e

FFFra force-pushed the fraschetti/wallet-temporarily-hide-activity-tab-on-collectible-detail-page branch 2 times, most recently from 674556d to c33c98b Compare April 2, 2024 13:33

clean code

e42b307

FFFra force-pushed the fraschetti/wallet-temporarily-hide-activity-tab-on-collectible-detail-page branch from c33c98b to e42b307 Compare April 2, 2024 13:58

FFFra merged commit 8c67ce0 into develop Apr 2, 2024
6 checks passed

FFFra deleted the fraschetti/wallet-temporarily-hide-activity-tab-on-collectible-detail-page branch April 2, 2024 14:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Wallet]Fraschetti/Temporarily hide Activity Tab on Collectible Detail Page #19447

[Wallet]Fraschetti/Temporarily hide Activity Tab on Collectible Detail Page #19447

FFFra commented Mar 28, 2024

status-im-auto commented Mar 28, 2024 •

edited

Loading

J-Son89 Mar 28, 2024

J-Son89 Mar 28, 2024

J-Son89 commented Mar 28, 2024

FFFra commented Apr 2, 2024

status-im-auto commented Apr 2, 2024

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityMultipleDevicePRTwo:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestDeepLinksOneDevice:

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

pavloburykh commented Apr 2, 2024

[Wallet]Fraschetti/Temporarily hide Activity Tab on Collectible Detail Page #19447

[Wallet]Fraschetti/Temporarily hide Activity Tab on Collectible Detail Page #19447

Conversation

FFFra commented Mar 28, 2024

Summary

Platforms

Areas that maybe impacted

Functional

Steps to test

Before and after screenshots comparison

Before

After

status-im-auto commented Mar 28, 2024 • edited Loading

Jenkins Builds

J-Son89 Mar 28, 2024

Choose a reason for hiding this comment

J-Son89 Mar 28, 2024

Choose a reason for hiding this comment

J-Son89 commented Mar 28, 2024

FFFra commented Apr 2, 2024

status-im-auto commented Apr 2, 2024

94% of end-end tests have passed

Failed tests (2)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityCenterContactRequestMultipleDevicePR:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (45)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityMultipleDevicePRTwo:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestDeepLinksOneDevice:

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

pavloburykh commented Apr 2, 2024

status-im-auto commented Mar 28, 2024 •

edited

Loading