Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add size variants to Step #552

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Conversation

felicio
Copy link
Collaborator

@felicio felicio commented Apr 25, 2024

No description provided.

Copy link

changeset-bot bot commented Apr 25, 2024

🦋 Changeset detected

Latest commit: 62e359e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@status-im/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 25, 2024

@felicio is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

@felicio felicio requested review from a team, jkbktl, prichodko and marcelines April 25, 2024 10:31
Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 8:16pm
status-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 8:16pm

Copy link
Collaborator

@jkbktl jkbktl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to set default size to every <Step> story otherwise <Step> component is not correctly rendered.

Copy link
Collaborator

@marcelines marcelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just that small consideration that @jkbktl referred.

packages/components/src/step/step.tsx Outdated Show resolved Hide resolved
@felicio felicio changed the title add size variants to Size add size variants to Step Apr 25, 2024
@felicio felicio merged commit 7093144 into status-im:main Apr 29, 2024
2 of 4 checks passed
@felicio felicio self-assigned this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants