feat: handle metric for peer connection failure #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
adklempner
force-pushed
the
feat/peer-conn-failure
branch
from
f7f96f2
to
dc55829
Compare
vpavlin
reviewed
Aug 2, 2024
| statusVersion VARCHAR(31), | ||
| failureCount INTEGER NOT NULL, | ||
| failedPeerId VARCHAR(255) NOT NULL, | ||
| CONSTRAINT peerConnFailure_unique unique(timestamp, peerId, failedPeerId, failureCount) |
There was a problem hiding this comment.
I am not sure about this index - the chance that the same peer will report the same failing peer with the same failure count is slim, but definitely not non-existent - any particular reason for this constraint?
There was a problem hiding this comment.
Including the timestamp should make it unique enough imo. It's mostly to prevent obvious duplicates (like if for whatever reason the client reports the same exact data twice).
There was a problem hiding this comment.
Huh, sorry, I missed the timestamp in there 🤦♂️
richard-ramos
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #21