Rename lsp to idris2-lsp
#127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In that case, would it make sense to rerun CI once the split has been merged? |
|
Sure! I'll let you know when it's merged. |
|
Merged. Let's try again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are about to split
idris2-lspintoLSP-lib(reusable model of LSP written in idris2) andidris2-lspthat will depend onLSP-lib.LSP-libencourages authors to write LSP servers for other programming languages in Idris2. So it makes sense to change the name under whichidris2-lspis distributed via pack from genericlspto more specificidris2-lsp.EDIT: I guess CI will only pass when we merge the split.