Fix Rebuild counter cache #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before ====== New records had the children counter cache value of nil. On mysql, update_counter_cache sets nodes with no children to nil. After ===== New records have the children counter cache set to 0 On mysql, update_counter_cache now sets to 0 (was nil) new records set the nodes with no children to have a count of 0. Docs ==== Looks like there is no documentation for the child counter cache. Need to add to the README\
Before ====== We were casting to a fixed length char field. This can truncate parts of the path After ===== Using the conversion built into concat, so no need to CAST. MySQL works best with CHAR Postgresql works better with VARCHAR
|
🙏🏻 |
kbrock
force-pushed
the
rebuild-counter-cache
branch
from
353f42f
to
3e25711
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alt to #665
Before
After
CONCAT, so no need to useCAST.