Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow private helm repo auth in dependencies #35

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Allow private helm repo auth in dependencies #35

merged 1 commit into from
Nov 16, 2022

Conversation

zzorica
Copy link
Contributor

@zzorica zzorica commented Nov 16, 2022 •
edited by stefanprodan
Loading

Fix: #31

@stefanprodan

Sorry but I just couldnt figure that 2nd commit in my previous PR and somehow ended up making a new one 😞

I hope thats ok

@zzorica zzorica mentioned this pull request Nov 16, 2022
Closed
stefanprodan
stefanprodan approved these changes Nov 16, 2022
View reviewed changes
Copy link
Owner

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @zzorica

@stefanprodan stefanprodan changed the title allow private helm repo auth in dependencies Allow private helm repo auth in dependencies Nov 16, 2022
@stefanprodan stefanprodan merged commit 0ad2bb3 into stefanprodan:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail to publish charts with dependencies stored on the same repository (when private)
2 participants
@zzorica @stefanprodan