Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add topologySpreadConstraints and PDB #331

Merged
merged 1 commit into from
Feb 28, 2024
Merged

feat(helm): add topologySpreadConstraints and PDB #331

merged 1 commit into from
Feb 28, 2024

Conversation

the-technat
Copy link
Contributor

Hi there

First of all thank you very much for podinfo! It's such a nice app and I used it heavily in the last couple of days to check app availability during migration testing.

Duing so I found myself looking for config options to specify topologySpreadConstraints and podDisruptionBudget in the helm chart which I didn't found. They are often used to ensure maximum availability during upgrades.

So here they are ;)

Tests done: only helm template locally

@the-technat
Copy link
Contributor Author

Any feedback on this?

@stefanprodan
Copy link
Owner

@the-technat can you please rebase with upstream master branch and force push so that CI passes. Thanks

@the-technat
Copy link
Contributor Author

Should be rebased.

Copy link
Owner

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @the-technat

@stefanprodan stefanprodan merged commit 47090ad into stefanprodan:master Feb 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants