GRPC Apis for Corresponding HTTP APIs #369
Conversation
There was a problem hiding this comment.
@Prashant-Dwivedi-08-01 can you please document all added functions in the main README under gRPC API? Thanks
Signed-off-by: Prashant Dwivedi <[email protected]>
|
@stefanprodan As per your comment, I have added description of all the gRPC APIs in the main README, you can review it once. Please see if you can help. Thanks |
|
Please rebase with the master branch, CI should be fixed. |
|
@stefanprodan thanks for that recommendation. CI is fixed. You can consider reviewing once and approving the PR. Thanks |
pkg/api/grpc/status.go
Outdated
| logger *zap.Logger | ||
| } | ||
|
|
||
| // SayHello implements helloworld.GreeterServer |
There was a problem hiding this comment.
Please remove this and the other lines below of commented code
There was a problem hiding this comment.
Did that! Removed unnecessary comments and whitespaces in code.
Please Check Once. Thanks
Signed-off-by: Prashant Dwivedi <[email protected]>
|
Can you please run |
Signed-off-by: Prashant Dwivedi <[email protected]>
@stefanprodan did that! |
Hey @stefanprodan
This PR is in the continuation of our previous effort to include the gRPC APIs for podinfo to extend it's application.
Previous Approved PR: #322
We introduced few APIs last time to test the stability of Podinfo with those. Now we are ready with remaining set of APIs.
Please have a look at this PR that includes the remaining set of APIs.
Thank You
Fix: #318