App zone history #18
Merged
App zone history #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enricogior
reviewed
Feb 5, 2020
enricogior
reviewed
Feb 5, 2020
enricogior
reviewed
Feb 5, 2020
stefansjfw
approved these changes
Feb 5, 2020
SeraphimaZykova
force-pushed
the
AppZoneHistory
branch
from
61fc6d8
to
f985000
Compare
enricogior
reviewed
Feb 5, 2020
| const auto& fancyZonesData = JSONHelpers::FancyZonesDataInstance(); | ||
|
|
||
| OLECHAR* guidString; | ||
| StringFromCLSID(activeZoneSet->Id(), &guidString); |
There was a problem hiding this comment.
For APIs that return HRESULT, it's better to check it instead of assuming they will always succeed.
enricogior
reviewed
Feb 5, 2020
| if (activeZoneSet) | ||
| { | ||
| OLECHAR* guidString; | ||
| StringFromCLSID(activeZoneSet->Id(), &guidString); |
|
@vldmr11080 |
|
I tested the latest code and it looks OK, the Json is updated with the correct data. |
SeraphimaZykova
added a commit
that referenced
this pull request
Feb 10, 2020
* added window and zone set ids to app zone history
stefansjfw
added a commit
that referenced
this pull request
Feb 23, 2020
…oft#1194) * Migrate FancyZones data persisting from Registry to JSON file * Address PR comment: Remove redundant check * Addres PR comment: Remove unused Dpi and add CmdArgs enum * Address PR comment: Make methods const and inline * Address PR comments: Expose GenerateUniqueId function and use const ref instead of passing wstring by value * Address PR comment: Use lamdba as callback * Address PR comment: Move GenerateUniqueId to ZoneWindowUtils namespace * Address PR comment: Use regular comparison instead of std::wstring::compare * Address PR comment: Use std::wstring_view for tmp file paths * Address PR comment: Use scoped lock when accessing member data * Address PR comment: Remove typedefs to increase code readability * Address PR comment: removed nullptr checks with corresponding tests * Address PR comment: Move ZoneSet object instead of copying * Address PR comment: Make FancyZonesData instance const where possible * Remove unnecessary gutter variable during calculating zone coordinates * Remove uneeded subclass * Avoid unnecessary copying and reserve space for vector if possible * Save FancyZones data after exiting editor * App zone history (#18) * added window and zone set ids to app zone history * Rename JSON file * Remove AppZoneHistory migration * Move parsing of ZoneWindow independent temp files outside of it * Unit tests update (#19) * check device existence in map * updated ZoneSet tests * updated JsonHelpers tests * Use single zone count information * Remove uneeded tests * Remove one more test * Remove uneeded line * Address PR comments - Missing whitespace * Update zoneset data for new virtual desktops (#21) * update active zone set with actual data * Introduce Blank zone set (used to indicate that no layout applied yet). Move parsing completely outside of ZoneWindow. * Fix unit tests to match modifications in implementation * Fix applying layouts on startup (second monitor) Co-authored-by: vldmr11080 <[email protected]> Co-authored-by: Seraphima <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
added zoneset id and device id to app zone history