Add "disable_globbing" option to prevent shell from expanding filenames #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #153.
This PR adds a new
disable_globbing
option to the Action. This will prevent the shell from expanding filenames.You can find more details about globbing in bash here:
-f
)Why
As reported in #153, in certain scenarios the Action fails to commit changed files. A test has been added to cover this edge case in e610a51.
My first instinct was to disable globbing globally for all executions. But after reading more about
set -o noglob
I've decided to hide this feature behind a new option.My gut tells me, that disabling globbing for all would lead just to more problems. 🤷
Bash Script for local testing
I've used the follwing shell script to test the in #153 reported edge case.