Feature/key info #38
Open
Feature/key info #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
reviewed
Aug 18, 2017
| /// Returns a string that describes the intended key usages of the certificate. | ||
| pub fn key_usage(&self) -> Option<String> { | ||
| unsafe { | ||
| println!("Getting Key usage"); |
| pub fn key_usage(&self) -> Option<String> { | ||
| unsafe { | ||
| println!("Getting Key usage"); | ||
| if (*self.0).pCertInfo.is_null() { |
There was a problem hiding this comment.
I don't think we need this check.
| if keyUsageExtension.is_null() { | ||
| return None; | ||
| } else { | ||
| let mut len = 500; |
sfackler
reviewed
Aug 18, 2017
| if (*self.0).pCertInfo.is_null() { | ||
| return None; | ||
| } | ||
| let mut keyUsageExtension = crypt32::CertFindExtension(szOID_KEY_USAGE.as_ptr() as winapi::LPSTR, (*(*self.0).pCertInfo).cExtension, (*(*self.0).pCertInfo).rgExtension); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function adds the ability to gather the Key Usage info in string format from a cert context.
This can be used to filter certs provided to a Tls_Stream in the security context such that non-signature keys are not supplied. I have been experiencing issues where the server requests client certificate validation but the client supplies symmetric (S/MIME) keys, causing the request to crash server-side.