Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest/ledgerbackend: Remove captive core info request error logs #5145

Merged

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Dec 19, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Captive core configures two prometheus metrics which periodically probe the info http endpoint on captive core. If the info request fails, we currently log the error.

Why

This commit removes the logs because we are already probing the info http endpoint and logging errors in https://github.com/stellar/go/blame/master/services/horizon/internal/app.go#L401C15-L401C36 . Therefore the logs here are redundant. Also, in #4894 and #5108 we added logic to suppress error logs during the build state, and if we keep this logging code we will have to reimplement this logic again.

Known limitations

[N/A]

@tamirms tamirms changed the base branch from master to release-horizon-v2.28.0 December 19, 2023 09:38
@tamirms tamirms merged commit d1e4c7c into stellar:release-horizon-v2.28.0 Dec 20, 2023
28 checks passed
@tamirms tamirms deleted the remove-info-error-logs branch December 20, 2023 09:30
sreuland pushed a commit to sreuland/go that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants