Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest/ledgerbackend: Fix captive core toml history entries #5150

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Jan 5, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Remove trailing slash from history archive urls when generating the captive core toml file.

Why

If you ran the horizon db reingest range command with a NETWORK configured to pubnet, the command would fail because the history archive urls we use all have trailing slashes:

https://github.com/stellar/go/blob/master/network/main.go#L26-L28

This would result in core making curl requests to invalid urls.

Known limitations

[N/A]

@tamirms tamirms marked this pull request as ready for review January 5, 2024 09:09
@tamirms tamirms merged commit bd8533a into stellar:release-horizon-v2.28.0 Jan 5, 2024
28 checks passed
@tamirms tamirms deleted the fix-toml-history branch January 5, 2024 18:01
@urvisavla
Copy link
Contributor

Considering whether removing the trailing slash here is a better option as it seems to be used in this?

@tamirms
Copy link
Contributor Author

tamirms commented Jan 5, 2024

@urvisavla history archive urls can be configured via command line. So, even if we strip the trailing slash in https://github.com/stellar/go/blob/master/network/main.go#L26-L28 , it is still possible for horizon to fail a reingest command because the history archive urls provided by the user contain a trailing slash

sreuland pushed a commit to sreuland/go that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants