Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tradeagg rebuild from reingest command with parallel workers #5168

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

sreuland
Copy link
Contributor

@sreuland sreuland commented Jan 17, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

for reingest command, consolidate the invocations of rebuilding of trade agg buckets to once at end of all parallel workers

Why

this avoids getting:

Error rebuilding trade aggregations: could not rebuild trade aggregation bucket: exec failed: pq: duplicate key value violates unique constraint \"history_trades_60000_pkey\

at the end of a parallel worker's range ingestion

Closes #5127

Known limitations

this is targeting the 2.28.0 release branch, it will be ported to master as part of porting the final release back to master later.

@sreuland sreuland changed the title Tradeagg rebuild Fix tradeagg rebuild from reingest command with parallel workers Jan 17, 2024
Copy link
Contributor

@urvisavla urvisavla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reingestion logic has some intricacies but the changes lgtm.

@sreuland sreuland merged commit 33bf9b6 into stellar:release-horizon-v2.28.0 Jan 18, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants