ingest/ledgerbackend: Add version check for protocol 21 #5346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
urvisavla
force-pushed
the
remove-core-version-check
branch
2 times, most recently
from
4c36e8e
to
b32aad8
Compare
urvisavla
changed the title
|
you can also remove protocol 20 from the integration tests matrix https://github.com/stellar/go/blob/master/.github/workflows/horizon.yml#L16 |
tamirms
approved these changes
Jun 14, 2024
|
@urvisavla I think you meant to say "Removing checks for core versions older than protocol 21," right? |
urvisavla
changed the title
yes, thank you. |
sreuland
reviewed
Jun 14, 2024
urvisavla
force-pushed
the
remove-core-version-check
branch
3 times, most recently
from
e9de3a2
to
2fbbde2
Compare
urvisavla
changed the title
urvisavla
changed the title
…ol version and update ledgerexporter and captivecorebackend to use these shared functions. Implement a version check for protocol 21 when creating a new captive-core instance.
urvisavla
force-pushed
the
remove-core-version-check
branch
from
2fbbde2
to
ffc70d0
Compare
sreuland
reviewed
Jun 18, 2024
sreuland
reviewed
Jun 18, 2024
sreuland
reviewed
Jun 18, 2024
sreuland
reviewed
Jun 18, 2024
sreuland
reviewed
Jun 18, 2024
sreuland
reviewed
Jun 18, 2024
sreuland
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Added shared functions to get the stellar-core build version and protocol version:
GetCoreBuildVersionGetCoreProtocolVersionUpdated ledgerexporter and captivecorebackend to use these shared functions to get stellar-core build version.
Implemented a version check for protocol 21 when creating a new captive-core instance.
Why
We previously had the core build for Soroban in several places. Now that we're on protocol 21, we should check the protocol version instead of the core build version. For more details, see #5333.
Known limitations
Any system using captive-core will not be compatible with stellar-core versions older than 21.