Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/ingest: Fix ingestion duration metric so it includes time spent reaping lookup tables #5361

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Jun 27, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Fix ingestion duration metric so it includes time spent reaping lookup tables.

Why

s.maybeVerifyState(ingestLedger, ledgerCloseMeta.BucketListHash()) and s.maybeReapHistory(ingestLedger) occur asynchronously in other goroutines so they do not block the ingestion thread. However, s.maybeReapLookupTables(ingestLedger) executes synchronously and does block ingestion thread. So time spent executing s.maybeReapLookupTables(ingestLedger) should contribute to the ingestion duration.

Known limitations

[N/A]

@tamirms tamirms requested a review from a team June 27, 2024 13:50
@tamirms tamirms changed the title services/horizon/internal/ingest: Fix ingestion duration metric so it includes time reaping lookup tables services/horizon/internal/ingest: Fix ingestion duration metric so it includes time spent reaping lookup tables Jun 27, 2024
@tamirms tamirms merged commit 153bbcf into stellar:master Jun 27, 2024
22 of 23 checks passed
@tamirms tamirms deleted the ingestion-duration branch June 27, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants