Migrate code to use the native BigInt
type wherever possible.
#607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Minimizes usage of the external dependency
BigNumber
, preferring the nativeBigInt
.Why
Per @orbitlens' in stellar/js-stellar-sdk#792 (comment), this is an attempt to minimize usage of the
bignumber.js
external dependency.Unfortunately, a full replacement of the library is not possible for a key reason: we need big rationals for price management. Anything to do with offers supports passing real values as strings (that may exceed
number
) and we need to convert those to fractions for the XDR. This necessitates big rationals, whichBigInt
does not support, obviously. Until there's also a nativeBigRat
, we will needbignumber.js
in these (not really) niche cases.Known Limitations
Honestly, I'm not certain about the utility of this change given its potential bug surface. Since we still do need
bignumber.js
for big rational values, and since this is imported byoperation.js
, this will still need to be used by a giant portion of downstream consumers. (The number of people using the SDK but not usingOperation
is probably minuscule.)