Automatically sort maps to match Soroban environment expectations #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.74 kB (+0.05%) Total Size: 3.21 MB
|
sreuland
reviewed
Jun 27, 2024
sreuland
reviewed
Jun 27, 2024
| @@ -182,12 +182,12 @@ describe('parsing and building ScVals', function () { | |||
| scv = nativeToScVal( | |||
| { | |||
| hello: 'world', | |||
| goodbye: [1, 2, 3] | |||
| there: [1, 2, 3] | |||
There was a problem hiding this comment.
it's tough to grasp how expectations are validating the new sorting of keys from this test.
There was a problem hiding this comment.
So the main test for order was the earlier one. This test was evaluating that type was being used correctly, and there are some assertions about scv[0] and scv[1] that become out of order since goodbye comes before hello lexicographically, so instead of modifying the assertion checks I just changed the key name so it'd stay in the same order as before.
sreuland
approved these changes
Jun 27, 2024
re1ro
approved these changes
Jun 28, 2024
|
Thank you for the expedited solution! 😄 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes stellar/js-stellar-sdk#996 and stellar/js-stellar-sdk#966.
Note that test changes just involve changing the order of the map fields to be sorted accordingly in the "expected output" portion of the test.
Also, the diff is simpler if you turn whitespace off.