Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default auth entry sig expiration to 5-10min #1023

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: default auth entry sig expiration to 5-10min #1023

merged 1 commit into from
Sep 9, 2024

Conversation

chadoh
Copy link
Contributor

@chadoh chadoh commented Jul 30, 2024

Fixes #983

@chadoh chadoh mentioned this pull request Jul 30, 2024
Closed
dmkozh
dmkozh reviewed Jul 30, 2024
View reviewed changes
Copy link

@dmkozh dmkozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with the SDK, but the changing the default expiration to 100 ledgers from now LGTM. We might also need to add a simple way to customize this, but it doesn't have to be in this PR.

Shaptic
Shaptic approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk why there's the prettier stuff but CI runs yarn run _prettier so please give that a yeet. Otherwise LGTM!

src/contract/assembled_transaction.ts Show resolved Hide resolved
@chadoh
Copy link
Contributor Author

chadoh commented Sep 9, 2024

I think my editor config was accidentally applying default prettier settings. I've fixed it and removed the unneeded commit.

@Shaptic Shaptic merged commit 3e081ba into stellar:master Sep 9, 2024
9 of 10 checks passed
@chadoh chadoh deleted the fix/default-expiration branch September 10, 2024 14:58
@Shaptic Shaptic mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmkozh dmkozh dmkozh left review comments

@Shaptic Shaptic Shaptic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default Soroban signature expiration is too high
3 participants
@chadoh @Shaptic @dmkozh