Cackle gate #1124
Merged
Cackle gate #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graydon
force-pushed
the
cackle-gate
branch
5 times, most recently
from
31c43b6
to
bffdaf6
Compare
dmkozh
approved these changes
Oct 23, 2023
github-merge-queue bot
pushed a commit
to stellar/rs-soroban-sdk
that referenced
this pull request
Oct 24, 2023
### What Use a seeded StdRng instead of thread_rng in arbitrary tests. ### Why Per stellar/rs-soroban-env#810 randomized test cases should be deterministic. ### Known limitations This is different from the approach in soroban-env-host from stellar/rs-soroban-env#1124, where a test prng is attached to the env / host. There are two more uses of thread_rng in this crate, but I don't know enough about that code to know how they should be removed, i.e. if they should follow a pattern similar to soroban-env-host. I am willing to replace all uses of thread_rng if given guidance about the preferred way to do it. The implementation of StdRng is allowed to change in the future, so it's possible the exact numbers generated could change. I could import rand_chacha instead if desired. Co-authored-by: Leigh McCulloch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a transitive-API-usage-checker called
cackleto the soroban build. It is currently (with a few exceptions) wired to prohibit most uses of the filesystem, network, time, the environment, threading, random numbers or hashtables. It's configured by cackle.toml and there's a new Makefile and github action target for it.I also took the opportunity to eliminate all uses of HashMap and thread_rng (see #810).
Thanks to @SirTyson for suggesting this tool! It was a little tricky to get working right but once working it seems good.