Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require TryFrom::Error to impl Debug #162

Merged
merged 3 commits into from
Jul 5, 2022
Merged

Require TryFrom::Error to impl Debug #162

merged 3 commits into from
Jul 5, 2022

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Jul 5, 2022

@jonjove
Copy link
Contributor

jonjove commented Jul 5, 2022

Related to #161

@leighmcculloch leighmcculloch enabled auto-merge (squash) July 5, 2022 19:16
@leighmcculloch
Copy link
Member Author

Note that in the future, once associated type bounds (rust-lang/rust#52662) are stabilized, we'd probably be able to omit the need for the constraint on every function in the SDK. We'd be able to change the definition of IntoTryFromVal so that it bounds the TryFrom::Error to Debug with the following change. Likely a similar change in the env crate would help us out up and down the stack.

- pub trait IntoTryFromVal: IntoVal<Env, RawVal> + TryFromVal<Env, RawVal> {
+ pub trait IntoTryFromVal: IntoVal<Env, RawVal> + TryFromVal<Env, RawVal, Error: Debug> {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce Usage of map_err
2 participants