Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated getLedgerEntry endpoint #276

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

aditya1702
Copy link
Contributor

@aditya1702 aditya1702 commented Aug 27, 2024

What

Closes #258

  • Remove the GetLedgerEntry code completely.

Why

It was already deprecated in favor of GetLedgerEntries and is not documented in our docs.

Known limitations

NA

Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yeah 👏

Any reason why this is still in draft? If not I can ✔️

@aditya1702 aditya1702 marked this pull request as ready for review August 28, 2024 13:22
@aditya1702
Copy link
Contributor Author

hell yeah 👏

Any reason why this is still in draft? If not I can ✔️

@Shaptic Oops my bad. I normally keep PRs in draft in case there are any failing tests. Forgot move it to in review

@aditya1702 aditya1702 changed the base branch from main to protocol22 September 4, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the deprecated getLedgerEntry endpoint
3 participants