Draft: Recover SCP messages when replaying from history #4156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enables updating the `scphistory` table during catchup from history. It allows users to specify which archives to use via the `SCP_HISTORY_ARCHIVES` config option. If a user specifies multiple archives, stellar-core will merge the messages from the archives. This is a draft PR because I'm looking for feedback on the approach, but still have some work to do before it is in a mergeable state. Most of the remaining work is to: * Document the new functionality * Write additional tests for: * Merging * Failed downloads * No `SCP_HISTORY_ARCHIVES` * Multiple `SCP_HISTORY_ARCHIVES` * Changes to `ReplayDebugMetaWork` * Integrate changes from stellar#4121 * Address other `TODO`s in the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3512
This PR enables updating the
scphistorytable during catchup from history. It allows users to specify which archives to use via theSCP_HISTORY_ARCHIVESconfig option. If a user specifies multiple archives, stellar-core will merge the messages from the archives.This is a draft PR because I'm looking for feedback on the approach, but still have some work to do before it is in a mergeable state. Most of the remaining work is to:
SCP_HISTORY_ARCHIVESSCP_HISTORY_ARCHIVESReplayDebugMetaWorkTODOs in the changesChecklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)