Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog using fresh changelog file from master #534

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

amishas157
Copy link
Contributor

@amishas157 amishas157 commented Nov 6, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the README with the added features, breaking changes, new instructions on how to use the repository.

What

This PR updates changelog generate module so as to:

  • Use changelog from master branch as original changelog instead of changelog from current branch.

Why

This is to avoid:

  • updating changelog file multiple times for different commits
  • clean any updates if final diff does not contain any schema changes

Known limitations

[TODO or N/A]

@amishas157 amishas157 force-pushed the patch/use-fresh-changelog-file branch from 2085f0e to 1a7666c Compare November 6, 2024 16:09
@amishas157 amishas157 marked this pull request as ready for review November 6, 2024 18:01
@amishas157 amishas157 requested a review from a team as a code owner November 6, 2024 18:01
@amishas157
Copy link
Contributor Author

It looks like CI won't run when the last commit is made by github action bot. Context in https://github.com/orgs/community/discussions/50468#discussioncomment-5366823

The problem is that the push is done using the GITHUB_TOKEN, which won't create new workflow runs, so the required checks never happen for the automatically created commit. If you want the push to create new workflow runs, you need to use a PAT instead to authorized the push (generally the best way to do it is to pass it to actions/checkout using its token parameter).

To help with that I am testing using PAT and adding a base statement so as to not recursively call workflow.
Testing done in amishas157#1

Also, working with ops to set up a PAT secret in this repo.

Screenshot 2024-11-06 at 2 09 52 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants