Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer SEPS: deprecate refunded boolean, add refunds object to transaction records #1128

Merged
merged 26 commits into from
Feb 17, 2022
Merged

Transfer SEPS: deprecate refunded boolean, add refunds object to transaction records #1128

merged 26 commits into from
Feb 17, 2022

Commits on Feb 15, 2022

  1. make initial changes for SEP-6

    @JakeUrban
    JakeUrban committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    66c2033 View commit details
    Browse the repository at this point in the history

  2. make changes to SEP-24 and SEP-31

    @JakeUrban
    JakeUrban committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    56db4e5 View commit details
    Browse the repository at this point in the history

  3. update based on PR comments

    @JakeUrban
    JakeUrban committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    cc6284f View commit details
    Browse the repository at this point in the history

  4. more corrections

    @JakeUrban
    JakeUrban committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    87a0bd8 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. clarify when refunded should be true

    @JakeUrban
    JakeUrban committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    fe3a01d View commit details
    Browse the repository at this point in the history

  2. added 'fee' and 'total_fee' attributes to 'refunds' object schema

    @JakeUrban
    JakeUrban committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    4f81286 View commit details
    Browse the repository at this point in the history

  3. add changelogs

    @JakeUrban
    JakeUrban committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    0b47461 View commit details
    Browse the repository at this point in the history

  4. update example json bodies

    @JakeUrban
    JakeUrban committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    08cc6c5 View commit details
    Browse the repository at this point in the history

  5. added amount formulas

    @JakeUrban
    JakeUrban committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    f8c6671 View commit details
    Browse the repository at this point in the history

  6. fix markdown

    @JakeUrban
    JakeUrban committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    640b52a View commit details
    Browse the repository at this point in the history

  7. rename header

    @JakeUrban
    JakeUrban committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    ea32698 View commit details
    Browse the repository at this point in the history

  8. Update ecosystem/sep-0006.md 

    Co-authored-by: Leigh McCulloch <[email protected]>
    @JakeUrban @leighmcculloch
    JakeUrban and leighmcculloch authored Feb 16, 2022
    Configuration menu
    Copy the full SHA
    e7f6d4f View commit details
    Browse the repository at this point in the history

  9. Update ecosystem/sep-0006.md 

    Co-authored-by: Leigh McCulloch <[email protected]>
    @JakeUrban @leighmcculloch
    JakeUrban and leighmcculloch authored Feb 16, 2022
    Configuration menu
    Copy the full SHA
    ec143fc View commit details
    Browse the repository at this point in the history

  10. Update ecosystem/sep-0006.md 

    Co-authored-by: Leigh McCulloch <[email protected]>
    @JakeUrban @leighmcculloch
    JakeUrban and leighmcculloch authored Feb 16, 2022
    Configuration menu
    Copy the full SHA
    cc1a35a View commit details
    Browse the repository at this point in the history

  11. Update ecosystem/sep-0006.md 

    Co-authored-by: Leigh McCulloch <[email protected]>
    @JakeUrban @leighmcculloch
    JakeUrban and leighmcculloch authored Feb 16, 2022
    Configuration menu
    Copy the full SHA
    bcca155 View commit details
    Browse the repository at this point in the history

  12. add 'as refunds' to other SEPs

    @JakeUrban
    JakeUrban committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    f56e084 View commit details
    Browse the repository at this point in the history

  13. add note about external id's not being unique

    @JakeUrban
    JakeUrban committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    e9e04d9 View commit details
    Browse the repository at this point in the history

  14. rephrase 'refunded' definition in other SEPs

    @JakeUrban
    JakeUrban committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    e58f3a9 View commit details
    Browse the repository at this point in the history

  15. update grammar in changelog for other SEPs

    @JakeUrban
    JakeUrban committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    46b996b View commit details
    Browse the repository at this point in the history

  16. fix amount fee references in formulas

    @JakeUrban
    JakeUrban committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    d809b70 View commit details
    Browse the repository at this point in the history

  17. use non-zero amount for refund fee examples

    @JakeUrban
    JakeUrban committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    23b8e60 View commit details
    Browse the repository at this point in the history

  18. always use 'in units of amount_in_asset''

    @JakeUrban
    JakeUrban committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    210ce25 View commit details
    Browse the repository at this point in the history

  19. add external id type examples

    @JakeUrban
    JakeUrban committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    b1b0347 View commit details
    Browse the repository at this point in the history

  20. remove claimable balance id from withdrawal transaction example

    @JakeUrban
    JakeUrban committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    7ee5dc5 View commit details
    Browse the repository at this point in the history

  21. missed update to SEP-24 transaction example

    @JakeUrban
    JakeUrban committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    d1ec273 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2022

  1. remove mention of 'type' attribute

    @JakeUrban
    JakeUrban committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    d7c74b9 View commit details
    Browse the repository at this point in the history