-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEP-9: Defined shared financial account fields #1367
Conversation
Address formatting varies widely from country to country and even within each country. See | ||
[here](https://stackoverflow.com/questions/11160192/how-to-parse-freeform-street-postal-address-out-of-text-and-into-components) | ||
for details. Rather than attempting to create a field for each possible part of an address in every country, this | ||
protocol takes a middle of the road approach. Address fields that are fairly universal can be encoded with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if address is universal, but we also need to include street name + building number?
What do we place in `address? Is it only building address, or full address?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think building/apt/suite numbers are typically separate optional fields in address forms. Maybe we should also have a separate field so we don't have this ambiguity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section hasn't been changed in this PR, so I suggest we keep things as-is for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but do we have any recommendations/guidance for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we do at the moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I think we should add some guidance for this field because right now it's quite confusing
The primary use of SEP-9 fields has been for collecting information on users of Stellar-based applications, including both KYC data and off-chain financial account data.
However, SEP-9 was also intended to be used by organizations to provide information to their users. This is particularly relevant in the context of SEP-6, where organizations need to provide off-chain financial account information to their customers in order for customers to fund their deposit transactions.
This PR clarifies the set of fields that can be used by applications such as anchors to both request that information from customers and provide that information to customers.
Unrelatedly, it also makes formatting changes for improved readability.