Update Github Action #581
Merged
Update Github Action #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arothian
commented
Nov 3, 2021
arothian
commented
- Support writing the output to a file
- Add a test for uploading sarif to GH code scanning
- Support writing the output to a file - Add a test for uploading sarif to GH code scanning
thegonch
reviewed
Nov 4, 2021
| @@ -0,0 +1,11 @@ | |||
| #!/bin/sh | |||
|
|
|||
| echo "::debug::Using input path: ${INPUT_INPUT_PATH}" | |||
There was a problem hiding this comment.
Not sure why the term INPUT precedes all of these variable names, especially when you have something like INPUT_OUTPUT_PATH that seems to just lend to confusion. I would suggest we just remove the extra leading INPUT for all of these var names.
There was a problem hiding this comment.
Yeah, it's somewhat unpleasant, but GH actions prefixes all configured inputs with INPUT_ and then exposes them as ENV variables. To the end user of the action though, they would just configure input_path, which maps well to the CLI naming. I could change it to path but then it would result in that disconnect.
thegonch
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.