-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bioc review changes #109
Merged
Merged
Bioc review changes #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to anndata-convert
Conflicts: README.Rmd README.md vignettes/Introduction.Rmd
Also I need input on this comment
|
stemangiola
requested changes
Apr 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @multimeric
- we should add titles to all figures
- the figures with fewer data do not look so impressive or informative; we should add the PNG (recalculated) version with all data below each plot. We should add the text above each full-data version to explain why we are showing this.
- I am not sure what the difference is between
and
If they are redundant, let's drop one of them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes suggested in Bioconductor/Contributions#2991
spelling
package to Suggests, and include it in tests. Technically this doesn't catch the "Angency" typo that was suggested, because that was inside a name field in the Description, whichspelling
never checks. But this in theory proves the lack of spelling mistakes elsewheredownsample_metadata()
, which should ensure the vignette builds much faster nowget_SingleCellExperiment()
to snake case:get_single_cell_experiment()
, with deprecation pathwayeval=FALSE
from all vignettes where relevantsessionInfo()
to vignetteassert_that()
calls into one where possible (those with custom error messages can't be)force(data)
which is functionally identical but has a clearer intenttissue_label.csv