New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace name #41

Merged

multimeric merged 1 commit into master from change-name

Feb 3, 2023

Owner

stemangiola commented Jan 23, 2023

@multimeric @vjcitn @mtmorgan

I am going through few names, I ended up with this

CuratedAtlasQuery

as they are three words that communicate

what this package does
it will extend to other atlases and organisms (e.g. mouse)
it will differentiate by the imminent CELLxGENE query system, which will not be biologically curated

What do you think? Any reservations?

Although less lean we might have to use

CuratedAtlasQueryR

as the python version will also be on github with the suffix Py

We could potentially keep CuratedAtlasQuery as package name and CuratedAtlasQueryR and github repository name, but it would create confusion in case devtools::install_github("...")


          replace name

e6dcb2b

stemangiola added the help wanted label

Collaborator

mtmorgan commented Jan 24, 2023 via email

The name sounds good to me! Adding R is better in my opinion than having a repo named differently from the package. Martin From: Stefano Mangiola ***@***.***> Date: Sunday, January 22, 2023 at 7:39 PM To: stemangiola/HCAquery_R ***@***.***> Cc: Martin Morgan ***@***.***>, Mention ***@***.***> Subject: [stemangiola/HCAquery_R] replace name (PR #41) @multimeric<https://github.com/multimeric> @vjcitn<https://github.com/vjcitn> @mtmorgan<https://github.com/mtmorgan> I am going through few names, I ended up with this CuratedAtlasQuery as they are three words that communicate * what this package does * it will extend to other atlases and organisms (e.g. mouse) * it will differentiate by the imminent CELLxGENE query system, which will not be biologically curated What do you think? Any reservations? Although less lean we might have to use CuratedAtlasQueryR as the python version will also be on github with the suffix Py We could potentially keep CuratedAtlasQuery as package name and CuratedAtlasQueryR and github repository name, but it would create confusion in case devtools::install_github("...")

________________________________ You can view, comment on, or merge this pull request online at: #41 Commit Summary * e6dcb2b<e6dcb2b> replace name File Changes (19 files<https://github.com/stemangiola/HCAquery_R/pull/41/files>) * M .gitignore<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947> (2) * M DESCRIPTION<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-9cc358405149db607ff830a16f0b4b21f7366e3c99ec00d52800acebe21b231c> (6) * M NEWS.md<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-51920e95310ebfbc1ae31709f3b95f89afffbf4f1a6e38e8b2b406e2fb6197ea> (2) * M dev/annotate_files.R<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-476ee53ac0d7eaa2e6f44f686f14fd8201c15631ccad85ad811d1f84be837a29> (40) * M dev/annotation_harmonise.R<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-4bfca16a84c196471bf957193f15dafab597daa55ad7984637656904f4e4f413> (414) * M dev/build_makefile_annotate_files.R<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-3162169fb7198735c05d2cba48199d8d2ab9238bcf1bfd25856c99039bd2bb8c> (73) * M dev/composition.R<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-96f2a10c2917abd9e63663002d4dd13526fa93c846023162c98e7953c3f51fdd> (219) * M dev/get_gene_names.R<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-5cc5b4cfcd5fb37e5b39e118b635fd11f115fea948a2ffb04614c3e61696ea8c> (39) * M dev/get_metadata.R<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-9f4966d4185ba98c34c57614f768aa2b9dd178f9e884c33aa8cfa8f2095be08d> (51) * M dev/liga.R<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-771475e02bca9c4aa4fe9997aaf85a66613b158c5b445fe8301ff350f11911b3> (663) * M dev/light_files.R<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-d97d6f56c2bd1311699f3e3c1cd8b5dceca6b2181576cccc320c6a6c4a0ebb88> (120) * M dev/merge_metadata.R<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-fcc9ec5ba34a888f8918f1633561b71cee71ab0a197347262736b46a6fec998c> (15) * M dev/scale_files.R<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-ecebd8ec1d16beba3cca22d75ce9d6e9259d2764a282bd08e8403a5e4e5dc356> (28) * M dev/split_files.R<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-a784daa6c243396bbd8159e57790b1f5ab843ee2fc50fb6b73e1cbafc53d540d> (91) * M dev/tissue_label_curated.csv<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-c5eb0273bd843cebcfed222cb782fa21a1bbf3b6322a3307a810d6e5387e92df> (32) * M readme.md<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-5a831ea67cf5cf8703b0de46901ab25bd191f56b320053be9332d9a3b0d01d15> (4) * M tests/testthat.R<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-9fab7e874754e477463ce086b5db508fd76d8a2f55451c5534e4f282f8de6b41> (4) * M tests/testthat/test-query.R<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-42bd523386e525f69eae60f196c22a2d79940eae9495f7621647e8b78f493197> (2) * M vignettes/readme.Rmd<https://github.com/stemangiola/HCAquery_R/pull/41/files#diff-ae256c0093d1ca73c59cb05d054f52d9502e23201f306a46ff09a8c7407291ae> (2) Patch Links: * https://github.com/stemangiola/HCAquery_R/pull/41.patch * https://github.com/stemangiola/HCAquery_R/pull/41.diff — Reply to this email directly, view it on GitHub<#41>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAA46GDAY7DBJA77NMBOWL3WTXHLRANCNFSM6AAAAAAUDJBPKY>. You are receiving this because you were mentioned.Message ID: ***@***.***>

multimeric requested changes

View reviewed changes

DESCRIPTION

@@ @@ -66,6 +66,6 @@ biocViews: @@
               Encoding: UTF-8
               RoxygenNote: 7.2.3
               LazyDataCompression: xz
-              URL: https://github.com/stemangiola/HCAquery
-              BugReports: https://github.com/stemangiola/HCAquery/issues
+              URL: https://github.com/stemangiola/CuratedAtlasQuery

Collaborator

multimeric Feb 3, 2023

These URLs are now out of date

dev/annotate_files.R Show resolved Hide resolved

multimeric merged commit a1dfc29 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels