Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used abstract type AbstractMatrix in encoding #4

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

ymtoo
Copy link
Contributor

@ymtoo ymtoo commented Apr 19, 2024

The PR fixes the error:

julia> x = Float16.(channelview(rand(RGB{N0f8}, 180, 320)))

julia> WebP.encode(colorview(RGB, N0f8.(x)))
ERROR: MethodError: no method matching encode(::Base.ReinterpretArray{RGB{N0f8}, 2, N0f8, Array{N0f8, 3}, true})

Closest candidates are:
  encode(::Matrix{TColor}; quality, transpose) where TColor<:Colorant
   @ WebP ~/.julia/packages/WebP/G4Y4q/src/encoding.jl:1

Stacktrace:
 [1] top-level scope
   @ REPL[34]:1

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.59%. Comparing base (682e7f0) to head (d9ff8fe).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   19.49%   23.59%   +4.10%     
==========================================
  Files           4        5       +1     
  Lines         354      373      +19     
==========================================
+ Hits           69       88      +19     
  Misses        285      285              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stemann
Copy link
Owner

stemann commented Apr 19, 2024

Thank you! Just in time for v0.1.0 🚀

@stemann stemann merged commit acdbb0f into stemann:master Apr 19, 2024
10 checks passed
@ymtoo ymtoo deleted the abstract-type branch April 20, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants