Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HTML): Do not indent <address> elements #764

Closed
nokome opened this issue Nov 23, 2020 · 1 comment
Closed

fix(HTML): Do not indent <address> elements #764

nokome opened this issue Nov 23, 2020 · 1 comment
Labels

Comments

@nokome
Copy link
Member

nokome commented Nov 23, 2020

It seems that the whitespace is introduced by Encoda's pretty printing indenting the <address> element in thema/src/examples/articleReplication.html:

    <li itemscope="" itemtype="http://schema.org/Organization" itemid="#author-organization-1"
      id="author-organization-1"><span itemprop="name">University of Georgia, Bioexpression and
        Fermentation Facility</span>
      <address itemscope="" itemtype="http://schema.org/PostalAddress" itemprop="address"><span
          itemprop="addressLocality">Georgia</span><span itemprop="addressCountry">United
          States</span></address>
    </li>

Note that there is no trailing whitespace in the <span itemprop="name"> element and if you remove the indentation of <address> the extra whitespace goes away.

Two options for changes in Encoda to rectify this:

  • use <span itemscope="" itemtype="http://schema.org/PostalAddress" itemprop="address"> instead of <address ....>
  • turn off indenting of <address> elems

Originally posted by @nokome in stencila/thema#261 (comment)

@nokome nokome closed this as completed in 7880a81 Nov 24, 2020
stencila-ci added a commit that referenced this issue Nov 24, 2020
## [0.103.1](v0.103.0...v0.103.1) (2020-11-24)

### Bug Fixes

* **HTML:** Do not indent <address> elements ([7880a81](7880a81)), closes [#764](#764)
@stencila-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 0.103.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants