Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change of inline elements #902

Open
rgieseke opened this issue Apr 12, 2021 · 2 comments
Open

Change of inline elements #902

rgieseke opened this issue Apr 12, 2021 · 2 comments

Comments

@rgieseke
Copy link
Contributor

Thanks for the merge of #896

Is the general workaround/change in
1ab835e#diff-fb6bbbe1b1c1c64434466345b13efc9495ced4ade665e4f015b3b40dc1471f33L1308

reasonable? Or is there a better approach?
This currently breaks install as i've only applied it to the JATS decoder.
@nokome
Copy link
Member

nokome commented Apr 12, 2021

Yes, that fix is the right one, but there are also other changes needed as a result of changes to how coercion to the schema is now activated for Article.content. I have tried to explain that in this PR #904.

My aim is to get that finished and do a release today.

@nokome
Copy link
Member

nokome commented Apr 13, 2021

I have merged #94 but there are still some weird results due to Ajv's weird coercion rule e.g. zero length string -> null and empty string (e.g. ' ') -> 0. I will fix those as soon as possible and certainly before next release.

nokome added a commit that referenced this issue Jun 18, 2021
@nokome
fix(Coercion): Default to no coercion
224a378 
There is an existing problem with Ajv based coercion described in #902.
This introduces spurious `null` values and other issues.
With some of the recent changes to the types of content (in particular
 `TableCell.content`?) this seems to be exacerbated.
 So this turns of coercion for the moment, to be dealt with in another PR.
stencila-ci added a commit that referenced this issue Jun 21, 2021
@stencila-ci
chore(release): 0.117.1 [skip ci]
ec156c0 
## [0.117.1](v0.117.0...v0.117.1) (2021-06-21)

### Bug Fixes

* Account for TableCell content potentially being undefined ([758b6ea](758b6ea))
* Use `MediaObject` `mediaType` rather than `format`; fix for content types ([186096e](186096e))
* **Build:** Avoid src in dist folder ([0105b6a](0105b6a)), closes [/github.com//pull/957#issue-671741247](https://github.com//github.com/stencila/encoda/pull/957/issues/issue-671741247)
* **Build:** Do not use compression withing binary ([c0517d4](c0517d4))
* **Build:** Include dist js in scripts ([d984c93](d984c93))
* **Coercion:** Default to no coercion ([224a378](224a378)), closes [#902](#902)
* **dependencies:** update dependency @stencila/thema to ^2.24.2 ([b4bf10b](b4bf10b))
* **dependencies:** update dependency globby to ^11.0.4 ([773a2f9](773a2f9))
* **dependencies:** update dependency papaparse to ^5.3.1 ([99ab93f](99ab93f))
* **dependencies:** update dependency puppeteer to v10 ([de23f29](de23f29))
* **dependencies:** update dependency trash to ^7.2.0 ([dda2194](dda2194))
* **Deps:** Add Schema to peerDependencies and update type guards ([fbd0214](fbd0214))
* **Deps:** Use Schema 1.9.0 ([13a347a](13a347a))
* **GDoc:** Use isA instead of isParagraph ([ffc83fc](ffc83fc))
* **HTML & JATS:** Use Mark.type instead of type map ([712d2f5](712d2f5))
* **Manifest:** Fix issue with the way that the plugin manifest was generated ([017aad3](017aad3))
* **Typings:** Fixes for changes in typing of CreativeWork content ([1a0fe89](1a0fe89))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgieseke @nokome