Remove non elife codecs #1079
Merged
Remove non elife codecs #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unnecessary asset build steps from the 'build:dist' command in package.json. Now only the 'build:tex-assets' step is included.
Remove 'build:tex-assets' from 'build:dist' command.
…move-non-elife-codecs
…move-non-elife-codecs
…move-non-elife-codecs
Changed the name of the third parameter in toInvert function from 'name' to 'fileName' for better readability and understanding.
Removed newline at the end of files in the crossref codec, specifically in file snapshots and fixtures files.
Updated the decode function and error log in person/index.ts to improve readability and code consistency.
Added JsonLdDocument type from jsonld to JSON parsing in decode function. This allows for better type checking and error handling. Also, expanded the JSON stringify parameters in the encode function.
Added JsonLdDocument type from jsonld to JSON parsing in decode function. This allows for better type checking and error handling. Also, expanded the JSON stringify parameters in the encode function.
…move-non-elife-codecs
Reorganized the encodeCsl, encodeArticle, and encodeCreativeWork functions in the csl codec. The functions are now more logically ordered, making the code easier to follow and maintain. No changes in functionality.
Reorder encodePerson, encodeOrganization, and encodeAuthor methods in src/codecs/csl/index.ts for improved readability and code structure.
Added methods to encode and decode Stencila `Date`, `Organization`, `CreativeWork` and `Person` nodes as `Csl.Date`, `string`, `Csl.Data` and `Csl.Person` objects respectively. Also moved some methods within the file for better organization.
This commit updates the code to include trailing commas in function arguments across multiple test files. It also adds two files to .prettierignore.
Added a trigger for pull requests targeting the master branch in the CI workflow. Also, removed 'kitchen-sink-xml--before.json' from .prettierignore.
nokome
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Thanks for this @soggy-mushroom @scottaubrey @will-byrne @nlisgo.
This looks fine to me. As mentioned elsewhere we should update the README to note this significant change in the scope of the project and look to reduce and update dependencies. But happy to merge this if you see fit.
Add announcement section explaining the shift in project focus to the development of the Stencila platform `v2`. Specify that from `v2.0.0` onwards, only the conversion from JATS to JSON will be supported. Also, remove references to unsupported codecs from the Codecs section.
nlisgo
reviewed
Aug 15, 2024
Added a list of multiple codecs to the README.md. Also, added a note indicating that the README.md is currently outdated even though a significant amount of code has been removed. Future updates to README.md are suggested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up the repo, so that EPP team is comfortable making further progress on encoda tickets.