Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add equation id and alttext for MathML in JATS #875

Merged
merged 3 commits into from
Mar 24, 2021

Conversation

rgieseke
Copy link
Contributor

Closes #872

rgieseke and others added 3 commits March 23, 2021 15:46
Refactoring so that the generated schema node only has properties that are
defined (i.e. no empty string for id, or altText)
@nokome
Copy link
Member

nokome commented Mar 24, 2021

Thanks for this @rgieseke 🙏🏽 . I did some refactoring to make the resulting node only has properties that are
defined (i.e. no empty string for id, or altText) and updated the test snapshots to reflect the change (npx jest -u).

@nokome nokome merged commit f72232d into stencila:master Mar 24, 2021
@stencila-ci
Copy link
Collaborator

🎉 This PR is included in version 0.111.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rgieseke rgieseke deleted the equation-id-alttext branch July 30, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Equation ID
3 participants