Skip to content
This repository has been archived by the owner on Jan 27, 2022. It is now read-only.

feat(Note): Draft Note specification #251

Merged
merged 4 commits into from
Mar 31, 2021
Merged

Conversation

rgieseke
Copy link
Collaborator

WIP, based on discussions in
stencila/encoda#880

@codecov-io
Copy link

codecov-io commented Mar 30, 2021

Codecov Report

Merging #251 (b187519) into master (f3dffef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   96.28%   96.28%           
=======================================
  Files          10       10           
  Lines         296      296           
  Branches       70       70           
=======================================
  Hits          285      285           
  Misses         11       11           
Flag Coverage Δ
py 98.03% <ø> (ø)
ts 95.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3dffef...b187519. Read the comment docs.

@nokome
Copy link
Member

nokome commented Mar 31, 2021

Thanks for getting this started @rgieseke . I consolidated the docs into the YAML. I realize that this is counter to the CONTRIBUTING.md - it's just that the md files are getting stale and difficult to maintain - it's easier if everything is in one file. We'll do a revamp of the docs and instructions soon.

I think this is ready to be merge, if you are happy with it.

schema/Note.schema.yaml Outdated Show resolved Hide resolved
@rgieseke rgieseke marked this pull request as ready for review March 31, 2021 20:56
@rgieseke
Copy link
Collaborator Author

LGTM, thanks! (Just a tiny wording suggestion.)

@nokome nokome merged commit 43a7d72 into stencila:master Mar 31, 2021
@stencila-ci
Copy link
Collaborator

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rgieseke rgieseke deleted the feat/note-spec branch April 1, 2021 06:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants