This repository has been archived by the owner on Nov 17, 2021. It is now read-only.
Update README.md #112
Merged
Update README.md #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-ketch
commented
Mar 18, 2020
Codecov Report
@@ Coverage Diff @@
## next #112 +/- ##
=======================================
Coverage 88.95% 88.95%
=======================================
Files 4 4
Lines 163 163
Branches 50 50
=======================================
Hits 145 145
Misses 18 18 Continue to review full report at Codecov.
|
This was suggested here: #114 (comment)
nokome
approved these changes
Mar 28, 2020
There was a problem hiding this comment.
Thanks for this @alex-ketch. Sorry for the delay - the review request slipped through.
I've added section on commit messages. Will merge into next with the view that we will then merge next into master with a breaking change commit message to bump to v2.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #95
As discussed yesterday with @nokome, the intention of this PR is primarily to proofread the README. A separate issue will be created for adding a raison d'être section to the README, outlining the decision making process for arriving at this implementation, pros/cons, etc.
🚨 This PR should be merged as a breaking change, to release a v2 for Thema. Switching the default branch to
masteragain.cc. @davidcmoulton so you're aware of the upcoming transition, though I don't think it should affect your work.