This repository has been archived by the owner on Nov 17, 2021. It is now read-only.
Fix theme styles and selector causing conflicts with Designa #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes have been sitting around for quite a bit awaiting some of the fixes in stencila/designa#26.
Seeing these themes in action on /Open, I want to reevaluate some of the decisions and structures around the selectors and how we're writing the themes. My current hunch is that we might want to establish rules of targeting only block level elements which are direct descendants of an
<article>
. Though the details need to be ironed out regarding how to deal with child elements that we want to style as well, such asol > li > figure
.