Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed NullPointerException & API-Change #9

Merged
merged 4 commits into from
Apr 5, 2020
Merged

Conversation

dennisfabri
Copy link

  1. Handled a situation where a NullPointerException was occurring.
  2. Made an API-Change to improve method signature

Further changes:

  • Updated dependencies

@steos
Copy link
Owner

steos commented Dec 1, 2019

Thank you very much! It looks good to me and I would like to merge this but it seems like there have been formatting changes and code has been moved around in the JnaFileChooser class. Can we fix this to have a clean diff?

@jwcharp
Copy link

jwcharp commented Jan 30, 2020

Any Ideas on how to preset the file name and extension on a SAVE dialog?

@jwcharp
Copy link

jwcharp commented Feb 1, 2020

Hi have forked and added functionality to set the title of the dialog along with preset the default file name and tried to simplify the structure as much as possible.

@dennisfabri
Copy link
Author

Sorry. I got distracted by other things. I will come back to this when I have the time.

@dennisfabri
Copy link
Author

Now I reduced the changes to the real modifications with minimal modifications to the code.

@steos
Copy link
Owner

steos commented Apr 5, 2020

Very cool, thanks for your efforts!

@steos steos merged commit 6f0eb6a into steos:master Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants