File based persisters should store all files under same folder. #103
Conversation
This patch allows each file persister to remove all cached files as previously but also removes the parent cache folder in order to allow cleaning all the remaining cached content from lazy/older persiters which did not clear their content. This patch also sanitizes not sanitized cache keys. Signed-off-by: David Marques <[email protected]>
|
Hi David, I will review your code tonight. Formatting problems make it hard to see the difference. Also, there are some aspects of the implementation that I would like to refactor but globally, it looks like all 2 features are working.) I shall be able to publish it tonight on master, if you could review the changes after I merge them, I would appreciate it. A simple question : how different is sanitation for cache keys in the cases of Databases and Files ? Thanks for this contribution, |
|
Sorry, I am pretty busy. It will take more time to merge these new features. But it's a top priority ! |
ghost
assigned 
|
The pull request could not be integrated as such. Feature has been reimplemented, extended and tested. It will be part of release 1.4.3. It would have been much easier to use RS formatting, commits were big and a lot of lines appeared to have change. Thx for your contribution, sorry not to have been able to use more of your work. |
This patch allows each file persister to remove all cached files
as previously but also removes the parent cache folder in order
to allow cleaning all the remaining cached content from lazy/older
persiters which did not clear their content.
This patch also sanitizes not sanitized cache keys.
Signed-off-by: David Marques [email protected]